Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix culture-dependent ToString in illink tests #96172

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

akoeplinger
Copy link
Member

We should be emitting the double/float string using invariant culture to avoid failures like this on cultures where decimal point is comma:

Expected:
    ldc.r8 2.5
    ret
Actual:
    ldc.r8 2,5
    ret

We should be emitting the double/float string using invariant culture to avoid failures like this on cultures where decimal point is comma:

```
Expected:
    ldc.r8 2.5
    ret
Actual:
    ldc.r8 2,5
    ret
```
@ghost ghost added the linkable-framework Issues associated with delivering a linker friendly framework label Dec 19, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Dec 19, 2023
@ghost ghost assigned akoeplinger Dec 19, 2023
@ghost
Copy link

ghost commented Dec 19, 2023

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar
See info in area-owners.md if you want to be subscribed.

Issue Details

We should be emitting the double/float string using invariant culture to avoid failures like this on cultures where decimal point is comma:

Expected:
    ldc.r8 2.5
    ret
Actual:
    ldc.r8 2,5
    ret
Author: akoeplinger
Assignees: -
Labels:

linkable-framework

Milestone: -

@akoeplinger akoeplinger added area-Tools-ILLink .NET linker development as well as trimming analyzers and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Dec 19, 2023
@akoeplinger akoeplinger merged commit d873a06 into dotnet:main Dec 19, 2023
74 of 76 checks passed
@akoeplinger akoeplinger deleted the fix-illink-culture branch December 19, 2023 15:21
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers linkable-framework Issues associated with delivering a linker friendly framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants