-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser][MT] fix CaptureContextFromParameter and SealJSImportCapturing #96504
Merged
pavelsavara
merged 8 commits into
dotnet:main
from
pavelsavara:browser_jsimport_fix_dispatch
Jan 6, 2024
Merged
[browser][MT] fix CaptureContextFromParameter and SealJSImportCapturing #96504
pavelsavara
merged 8 commits into
dotnet:main
from
pavelsavara:browser_jsimport_fix_dispatch
Jan 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- new test JSObject_CapturesAffinity - fixed ExecutorType.NewThread in tests - cleanup
pavelsavara
added
arch-wasm
WebAssembly architecture
area-System.Runtime.InteropServices.JavaScript
os-browser
Browser variant of arch-wasm
labels
Jan 4, 2024
Tagging subscribers to 'arch-wasm': @lewing Issue Details
|
kg
reviewed
Jan 4, 2024
...ropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSHostImplementation.cs
Show resolved
Hide resolved
kg
reviewed
Jan 4, 2024
...Runtime.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSObject.cs
Outdated
Show resolved
Hide resolved
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
kg
reviewed
Jan 4, 2024
...time.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSWebWorker.cs
Show resolved
Hide resolved
kg
reviewed
Jan 4, 2024
...rvices.JavaScript.UnitTests/System/Runtime/InteropServices/JavaScript/WebWorkerTestHelper.cs
Outdated
Show resolved
Hide resolved
kg
reviewed
Jan 4, 2024
looks good so far |
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
kg
approved these changes
Jan 4, 2024
31 tasks
… least one available threads is loaded into emscripten pool
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
All CI failures are known |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
arch-wasm
WebAssembly architecture
area-System.Runtime.InteropServices.JavaScript
os-browser
Browser variant of arch-wasm
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CaptureContextFromParameter
andSealJSImportCapturing
JSObject_CapturesAffinity
ExecutorType.NewThread
in testsschedule_background_exec
andmono_wasm_invoke_import_async