Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono][amd64] Fix Vector128 relational comparison API's for nuint type #96515

Merged
merged 3 commits into from
Jan 8, 2024
Merged

[mono][amd64] Fix Vector128 relational comparison API's for nuint type #96515

merged 3 commits into from
Jan 8, 2024

Conversation

fanyang-mono
Copy link
Member

@fanyang-mono fanyang-mono commented Jan 4, 2024 •
edited
Loading

This PR fixes the following Vector128 API's, when the argument type is nuint:

  • GreaterThan
  • GreaterThanAll
  • GreaterThanAny
  • GreaterThanOrEqual
  • GreaterThanOrEqualAll
  • GreaterThanOrEqualAny
  • LessThan
  • LessThanAll
  • LessThanAny
  • LessThanOrEqual
  • LessThanOrEqualAll
  • LessThanOrEqualAny

Fixes #96443

@ghost ghost assigned fanyang-mono Jan 4, 2024
@ghost
Copy link

ghost commented Jan 4, 2024

Tagging subscribers to this area: @SamMonoRT, @fanyang-mono
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR fixes the following Vector128 API's, when the argument type is uint:

  • GreaterThan
  • GreaterThanAll
  • GreaterThanAny
  • GreaterThanOrEqual
  • GreaterThanOrEqualAll
  • GreaterThanOrEqualAny
  • LessThan
  • LessThanAll
  • LessThanAny
  • LessThanOrEqual
  • LessThanOrEqualAll
  • LessThanOrEqualAny

Fixes #96443

Author: fanyang-mono
Assignees: -
Labels:

area-Codegen-Intrinsics-mono
Milestone: -

@fanyang-mono fanyang-mono changed the title [mono][amd64] Fix Vector128 relational comparison API's [mono][amd64] Fix Vector128 relational comparison API's for uint type Jan 4, 2024
@stephentoub
Copy link
Member

What about ulong? Does this also fix that?

And could you add tests?

@fanyang-mono fanyang-mono changed the title [mono][amd64] Fix Vector128 relational comparison API's for uint type [mono][amd64] Fix Vector128 relational comparison API's for nuint type Jan 5, 2024
@fanyang-mono
Copy link
Member Author

@stephentoub ulong has always been working properly. The problematic type is nuint, which is the same as UIntPtr. Yes, I will add a test for this.

@stephentoub
Copy link
Member

The problematic type is nuint, which is the same as UIntPtr

Yes, thanks, that's what I intended to write. The original PR description had uint rather than nuint.

@fanyang-mono
Copy link
Member Author

@stephentoub Yeah, I had a typo before. Sorry about the confusion.

@build-analysis build-analysis bot mentioned this pull request Jan 5, 2024
Closed
@fanyang-mono
Copy link
Member Author

CI lane dotnet-linker-tests (Build osx-x64 release Runtime_Release) seems to be stuck. It is irrelevant to the changes in this PR. Merging without waiting for it to be done.

@fanyang-mono fanyang-mono merged commit f0ca0fa into dotnet:main Jan 8, 2024
145 of 148 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tannergooding tannergooding tannergooding approved these changes

@vargaz vargaz vargaz approved these changes

@lambdageek lambdageek Awaiting requested review from lambdageek

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

Assignees

@fanyang-mono fanyang-mono

Labels
area-Codegen-Intrinsics-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vector128.LessThan broken for some UIntPtr values on mono
4 participants
@fanyang-mono @stephentoub @vargaz @tannergooding