Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Fix native memory leak on OCSP_Response #96578

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 6, 2024

Backport of #96561 to release/7.0-staging.
Fixes #96616.

/cc @rzikm

Customer Impact

Regression: Yes, after upgrade to .NET 7 or .NET 8, OCSP stapling is new by-default enabled feature (introduced by #67011) which introduced also the memory leak, if the app uses the “right” APIs and server supports OCSP.
Customer impact: 5 independent reports in last 6 months. Hard to diagnose issue (took at least 1 engineering month just to root cause)

Slow native memory leak under specific feature conditions (see below) leading to increased memory footprint and later application crash. Impacts service availability.

Affected scenario is a specific subset of client authentication during TLS connection:

Testing

Tested on a small application which reproduced the memory leak. The leak is gone after this change.
Customer validation:

Risk

Low, one-line change.

@ghost
Copy link

ghost commented Jan 6, 2024

Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #96561 to release/7.0-staging

/cc @rzikm

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Security

Milestone: -

@rzikm rzikm self-assigned this Jan 11, 2024
@carlossanlop
Copy link
Member

@rzkim - Friendly reminder that Tuesday January 16th 4pm is the Code Complete deadline for the February Release. If all requirements are met, please merge your PR before that date and time to ensure this fix gets included in that Release.

@karelz karelz added the Servicing-consider Issue for next servicing release review label Jan 15, 2024
@rzikm rzikm changed the title [release/7.0-staging] Fix native memory leak on OCSP_Response [release/7.0] Fix native memory leak on OCSP_Response Jan 15, 2024
@karelz karelz added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jan 16, 2024
@karelz
Copy link
Member

karelz commented Jan 16, 2024

Approved by Tactics (@SteveMCarroll) on 1/15 via email - label updated to Servicing-approved.

@rzikm
Copy link
Member

rzikm commented Jan 16, 2024

CI failure is unrelated (wasm)

@rzikm rzikm merged commit daeac23 into release/7.0-staging Jan 16, 2024
121 of 133 checks passed
@jkotas jkotas deleted the backport/pr-96561-to-release/7.0-staging branch January 20, 2024 03:19
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Security Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants