Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser][MT] - CancellationToken for JSWebWorker #96696

Merged
merged 9 commits into from
Jan 11, 2024

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Jan 9, 2024

- fix `UninstallWebWorkerInterop` for `JSWebWorker` when exception
- `ReleasePromiseHolder` operations order
- tests: `Executor_Cancellation`, `Executor_Propagates`
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Jan 9, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Jan 9, 2024
@pavelsavara pavelsavara requested review from kg, lambdageek and maraf January 9, 2024 17:40
@pavelsavara pavelsavara self-assigned this Jan 9, 2024
@pavelsavara pavelsavara requested a review from lewing as a code owner January 9, 2024 17:40
@ghost
Copy link

ghost commented Jan 9, 2024

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser

Milestone: 9.0.0

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara pavelsavara requested a review from kg January 10, 2024 20:10
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

I filled #96840, all other CI issues are well known

@pavelsavara pavelsavara merged commit c99789f into dotnet:main Jan 11, 2024
130 of 139 checks passed
@pavelsavara pavelsavara deleted the browser_worker_cancellation branch January 11, 2024 14:06
tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants