Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move setting variables to HelixPreCommands #96713

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Move setting variables to HelixPreCommands #96713

merged 2 commits into from
Jan 11, 2024

Commits on Jan 9, 2024

  1. Move setting variables to HelixPreCommands 

    Don't inject them in the generated RunTests.cmd script.

Namely, `__IsXUnitLogCheckerSupported=1` and `__TestArchitecture`.
    @BruceForstall
    BruceForstall committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    fc88ebc View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. Revert changes to __IsXUnitLogCheckerSupported=1 

    Just change `__TestArchitecture` setting.

I don't want to risk potential complications in the complex
way in which `__IsXUnitLogCheckerSupported` is chosen to be set.
    @BruceForstall
    BruceForstall committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    661765c View commit details
    Browse the repository at this point in the history