Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: Pass field's owner to getFieldType #96794

Closed
wants to merge 10 commits into from

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Jan 10, 2024

Closes #96787

Also, removes the variance check from:

private readonly List<string> _list = new() { "a", "b", "c" };

[Benchmark]
public Span<string> AsSpan() => CollectionsMarshal.AsSpan(_list);

Codegen diff (Main vs PR): https://www.diffchecker.com/dZnlDi91/

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 10, 2024
@ghost ghost assigned EgorBo Jan 10, 2024
@ghost
Copy link

ghost commented Jan 10, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Closes #96787

Also, removes the variance check from:

private readonly List<string> _list = new() { "a", "b", "c" };

[Benchmark]
public Span<string> AsSpan() => CollectionsMarshal.AsSpan(_list);

Codegen diff (Main vs PR): https://www.diffchecker.com/dZnlDi91/

Author: EgorBo
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@EgorBo
Copy link
Member Author

EgorBo commented Jan 10, 2024

@MihuBot

@EgorBo
Copy link
Member Author

EgorBo commented Jan 11, 2024

@MihuBot

@jkotas
Copy link
Member

jkotas commented Jan 12, 2024

Existing related codegen bug: #96876

@EgorBo
Copy link
Member Author

EgorBo commented Jan 14, 2024

@MihuBot

@EgorBo
Copy link
Member Author

EgorBo commented Jan 14, 2024

@MihuBot

@ghost
Copy link

ghost commented Feb 13, 2024

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2024
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JIT doesn't see real type of field in a shared generic type with exact context
3 participants