Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-staging] [mono][debugger] Fix debug lazy loaded assemblies when webcil is enabled #96825

Merged
merged 3 commits into from
Jan 13, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 11, 2024

Backport of #96800 to release/8.0-staging

/cc @thaystg

Customer Impact

Customer cannot debug lazy loaded assemblies in WASM apps when WebCil is enabled (which is the default behavior).

Testing

Manually tested.

Risk

Low risk, only sending the full content of the assembly to BrowserDebugProxy.

@ghost
Copy link

ghost commented Jan 11, 2024

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #96800 to release/8.0-staging

/cc @thaystg

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Debugger-mono

Milestone: -

@thaystg thaystg added the Servicing-consider Issue for next servicing release review label Jan 11, 2024
@lambdageek lambdageek added this to the 8.0.x milestone Jan 11, 2024
@carlossanlop
Copy link
Member

@thaystg Friendly reminder that Tuesday January 16th 4pm is the Code Complete deadline for the February Release. If all requirements are met, please merge your PR before that date and time to ensure this fix gets included in that Release.

@thaystg thaystg added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jan 13, 2024
@thaystg
Copy link
Member

thaystg commented Jan 13, 2024

Approved by email.

@thaystg thaystg merged commit 95a332e into release/8.0-staging Jan 13, 2024
26 of 27 checks passed
@akoeplinger akoeplinger modified the milestones: 8.0.x, 8.0.2 Jan 14, 2024
@akoeplinger akoeplinger deleted the backport/pr-96800-to-release/8.0-staging branch January 14, 2024 11:23
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Debugger-mono Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants