Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update riscv64 image to clang17 #96827

Closed
wants to merge 2 commits into from
Closed

Update riscv64 image to clang17 #96827

wants to merge 2 commits into from

Conversation

am11
Copy link
Member

@am11 am11 commented Jan 11, 2024

Current version: clang15
New version: clang17

Since risc-v is relatively a new architecture and toolchains are still in the process of implementing new extensions and optimizations overall, we should prefer the latest version for CI build validations.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jan 11, 2024
@ghost
Copy link

ghost commented Jan 11, 2024

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Current version: clang15
New version: clang17

Since risc-v is relatively a new architecture and toolchains are still in the process of implementing new extensions and optimizations overall, we should prefer the latest version for CI build validations.

Author: am11
Assignees: -
Labels:

area-Infrastructure-libraries, community-contribution

Milestone: -

@am11 am11 added area-Infrastructure arch-riscv Related to the RISC-V architecture and removed area-Infrastructure-libraries labels Jan 11, 2024
@ghost
Copy link

ghost commented Jan 11, 2024

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Current version: clang15
New version: clang17

Since risc-v is relatively a new architecture and toolchains are still in the process of implementing new extensions and optimizations overall, we should prefer the latest version for CI build validations.

Author: am11
Assignees: -
Labels:

area-Infrastructure, community-contribution, arch-riscv

Milestone: -

@am11
Copy link
Member Author

am11 commented Jan 11, 2024

riscv64 picked up clang 17.

-- The C compiler identification is Clang 17.0.6
-- The CXX compiler identification is Clang 17.0.6
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/clang-17 - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/clang++-17 - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
Detected Linux riscv64

@akoeplinger
Copy link
Member

Sounds good, but we don't need to merge the PR since the floating tag will get updated.

@am11
Copy link
Member Author

am11 commented Jan 11, 2024

ah, I thought the production ones take longer: https://github.com/dotnet/versions/commits/main/build-info/docker/image-info.dotnet-dotnet-buildtools-prereqs-docker-production.json, but apparently staging also push the floating tags (so what's the difference 🤷).

It was picked up in main via floating tag. So Closing. :)

@akoeplinger
Copy link
Member

akoeplinger commented Jan 12, 2024

Yeah looks like the -production.json is no longer used, it wasn't updated for almost a year. I've asked for clarification in dotnet/dotnet-buildtools-prereqs-docker#956

@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2024
@am11 am11 deleted the patch-26 branch June 14, 2024 04:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-riscv Related to the RISC-V architecture area-Infrastructure community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants