Remove IBC and Ngen related structures and comments #96867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove all IBC comments from the vm portion of the codebase - Remove `m_GenericTypeDefToCanonMethodTableMap` and `m_MehtodDefToPropertyInfoMap` which were only filled in by NGen - Remove a variety of flags enums which are never used - Remove infra for testing Zap and IBC scenarios
davidwrighton
requested review from
AaronRobinsonMSFT and
elinor-fung
and removed request for
AaronRobinsonMSFT
ghost
assigned 
elinor-fung
reviewed
Jan 11, 2024
elinor-fung
approved these changes
Jan 11, 2024
AaronRobinsonMSFT
approved these changes
Jan 11, 2024
src/coreclr/vm/ceeload.cpp
Outdated
| @@ -3439,7 +3418,6 @@ MethodDesc *Module::FindMethod(mdToken pMethod) | |||
|
|
|||
| // | |||
| // GetPropertyInfoForMethodDef wraps the metadata function of the same name, | |||
There was a problem hiding this comment.
Suggested change
| // GetPropertyInfoForMethodDef wraps the metadata function of the same name, | |
| // GetPropertyInfoForMethodDef wraps the metadata function of the same name. |
src/coreclr/vm/jitinterface.cpp
Outdated
| @@ -5700,17 +5700,17 @@ unsigned CEEInfo::getClassDomainID (CORINFO_CLASS_HANDLE clsHnd, | |||
|
|
|||
| //--------------------------------------------------------------------------------------- | |||
| // | |||
| // Used by the JIT to determine whether the profiler or IBC is tracking object | |||
| // Used by the JIT to determine whether the profiler is tracking object | |||
There was a problem hiding this comment.
Suggested change
| // Used by the JIT to determine whether the profiler is tracking object | |
| // Used by the JIT to determine whether the profiler is tracking object |
src/coreclr/vm/jitinterface.cpp
Outdated
| // allocations | ||
| // | ||
| // Return Value: | ||
| // bool indicating whether the profiler or IBC is tracking object allocations | ||
| // bool indicating whether the profiler is tracking object allocations |
There was a problem hiding this comment.
Suggested change
| // bool indicating whether the profiler is tracking object allocations | |
| // bool indicating whether the profiler is tracking object allocations |
src/coreclr/vm/zapsig.cpp
Outdated
| // During ngen this calls | ||
| // code:ZapImportTable.EncodeModuleHelper) | ||
| // During multicorejit this calls | ||
| // code:MulticoreJitManager.EncodeModuleHelper | ||
| // |
This was referenced Jan 12, 2024
Closed
EgorBo
reviewed
Jan 12, 2024
src/coreclr/inc/clrconfigvalues.h
Outdated
| @@ -662,8 +662,6 @@ RETAIL_CONFIG_DWORD_INFO(INTERNAL_EnableDumpOnSigTerm, W("EnableDumpOnSigTerm"), | |||
| /// | |||
| /// Zap | |||
| /// | |||
| RETAIL_CONFIG_STRING_INFO(INTERNAL_ZapBBInstr, W("ZapBBInstr"), "") | |||
| RETAIL_CONFIG_STRING_INFO(EXTERNAL_ZapBBInstrDir, W("ZapBBInstrDir"), "") | |||
| RETAIL_CONFIG_DWORD_INFO(EXTERNAL_ZapDisable, W("ZapDisable"), 0, "") | |||
There was a problem hiding this comment.
ZapDisabled is kept to maintain compatibility and is the same as ReadyToRun=0?
tmds
pushed a commit
to tmds/runtime
that referenced
this pull request
Jan 23, 2024
- Remove all IBC comments from the vm portion of the codebase - Remove `m_GenericTypeDefToCanonMethodTableMap` and `m_MehtodDefToPropertyInfoMap` which were only filled in by NGen - Remove a variety of flags enums which are never used - Remove infra for testing Zap and IBC scenarios - Remove ZapDisable as @EgorBo suggested
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
m_GenericTypeDefToCanonMethodTableMapandm_MethodDefToPropertyInfoMapwhich were only filled in by NGen