Remove more helper frames by converting methods to QCalls #96926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thread.SleepWorker Thread.GetIsBackground Thread.SetIsBackground Thread.Interrupt
AaronRobinsonMSFT
requested review from
jkotas,
davidwrighton and
elinor-fung
ghost
assigned 
src/coreclr/System.Private.CoreLib/src/Microsoft/Win32/OAVariantLib.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jan 13, 2024
src/coreclr/System.Private.CoreLib/src/System/Threading/Thread.CoreCLR.cs
Outdated
Show resolved
Hide resolved
src/coreclr/System.Private.CoreLib/src/Microsoft/Win32/OAVariantLib.cs
Outdated
Show resolved
Hide resolved
src/coreclr/System.Private.CoreLib/src/System/Threading/Thread.CoreCLR.cs
Outdated
Show resolved
Hide resolved
src/coreclr/System.Private.CoreLib/src/System/Threading/Thread.CoreCLR.cs
Outdated
Show resolved
Hide resolved
This was referenced Jan 13, 2024
Closed
jkotas
reviewed
Jan 16, 2024
| // Return whether or not this is a background thread. | ||
| FCIMPL1(FC_BOOL_RET, ThreadNative::IsBackground, ThreadBaseObject* pThisUNSAFE) | ||
| FCIMPL1(FC_BOOL_RET, ThreadNative::GetIsBackground, ThreadBaseObject* pThisUNSAFE) | ||
| { | ||
| FCALL_CONTRACT; | ||
|
|
There was a problem hiding this comment.
(for future PRs)
We will need to get rid of the FCThrowRes too. I think the best way to do it - without regressing performance - is to duplicate some of the state bits on the managed thread object, so that the IsDead check can be done in C#.
tmds
pushed a commit
to tmds/runtime
that referenced
this pull request
Jan 23, 2024
* Remove FCall in interop code * Convert DisableComObjectEagerCleanup to QCall. * Convert the following to QCalls. Thread.SleepWorker Thread.GetIsBackground Thread.SetIsBackground Thread.Interrupt * Feedback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.