JIT: Delete old DFS and dominator implementations #96927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove `BasicBlock::bbIDom`. Move it into `DomTreeNode` instead so that multiple dominator trees aren't sharing a field in the basic block. - Introduce `FlowGraphDominatorTree::BuildFromRegularFlow`. It builds a dominator tree over the regular flow, ignoring exceptional flow. Switch the block weighting logic to be based on this tree. - Remove the old DFS - Remove the old dominator computation - Remove the old `DomTreeVisitor` and rename `NewDomTreeVisitor` -> `DomTreeVisitor` - Rename `BasicBlock::bbNewPostorderNum` -> `BasicBlock::bbPostorderNum`
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue Details
Minor diffs expected due to differences in treatment of unreachable blocks when computing the new regular flow dominators.
|
jakobbotsch
commented
Jan 13, 2024
|
|
||
| if (!dfsTree->Contains(predBlock)) | ||
| { | ||
| DBG_SSA_JITDUMP(" Unreachable node\n"); |
There was a problem hiding this comment.
This was a preexisting bug. The below loop would read the bbIDom set by the old dominator computation in this case.
This was referenced Jan 13, 2024
Closed
|
cc @dotnet/jit-contrib PTAL @BruceForstall Diffs. Some minor code diffs, due to the more precise exceptional flow handling. Some larger TP improvements. |
This was referenced Jan 16, 2024
2 tasks
BruceForstall
approved these changes
Jan 16, 2024
tmds
pushed a commit
to tmds/runtime
that referenced
this pull request
Jan 23, 2024
- Switch the block weighting logic to be based on the new dominator tree - Remove the old DFS - Remove the old dominator computation - Remove the old `DomTreeVisitor` and rename `NewDomTreeVisitor` -> `DomTreeVisitor` - Rename `BasicBlock::bbNewPostorderNum` -> `BasicBlock::bbPostorderNum`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DomTreeVisitorand renameNewDomTreeVisitor->DomTreeVisitorBasicBlock::bbNewPostorderNum->BasicBlock::bbPostorderNumSome diffs expected due to the more precise handling of exceptional flow. Some TP improvements expected from removing some unnecessary DFS/dominator computations. More improvements should come with follow-ups to avoid some unnecessary recomputations.