[NativeAOT] Remove obsolete C++ name mangling #96983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue Detailsnull
|
| @@ -69,7 +64,7 @@ public override string SanitizeName(string s, bool typeName = false) | |||
| sb ??= new StringBuilder(s, 0, i, s.Length); | |||
|
|
|||
| // For CppCodeGen, replace "." (C# namespace separator) with "::" (C++ namespace separator) | |||
| if (typeName && c == '.' && _mangleForCplusPlus) | |||
There was a problem hiding this comment.
Shouldn't this whole if be removed ? In other places you remove code using the assumption that _mangleForCplusPlus is always false but now code in this if will be executed when it wasn't before.
(I don't have any context here so this change might be right. I just saw the change and I found it weird.)
There was a problem hiding this comment.
Yes, would be nice to delete the comment above too and other references to C++ in this file
There was a problem hiding this comment.
You are right. Thanks for noticing!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.