[main] Update dependencies from dotnet/arcade #97087

dotnet-maestro · 2024-01-17T10:10:25Z

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
Build: 20240119.2
Date Produced: January 19, 2024 1:45:17 PM UTC
Commit: abddd0bd5145578246dcadda264c7557f2a935a9
Branch: refs/heads/main

Updates:
- Microsoft.DotNet.Arcade.Sdk: from 9.0.0-beta.23607.2 to 9.0.0-beta.24069.2
- Microsoft.DotNet.Build.Tasks.Archives: from 9.0.0-beta.23607.2 to 9.0.0-beta.24069.2
- Microsoft.DotNet.Build.Tasks.Feed: from 9.0.0-beta.23607.2 to 9.0.0-beta.24069.2
- Microsoft.DotNet.Build.Tasks.Installers: from 9.0.0-beta.23607.2 to 9.0.0-beta.24069.2
- Microsoft.DotNet.Build.Tasks.Packaging: from 9.0.0-beta.23607.2 to 9.0.0-beta.24069.2
- Microsoft.DotNet.Build.Tasks.TargetFramework: from 9.0.0-beta.23607.2 to 9.0.0-beta.24069.2
- Microsoft.DotNet.Build.Tasks.Templating: from 9.0.0-beta.23607.2 to 9.0.0-beta.24069.2
- Microsoft.DotNet.Build.Tasks.Workloads: from 9.0.0-beta.23607.2 to 9.0.0-beta.24069.2
- Microsoft.DotNet.CodeAnalysis: from 9.0.0-beta.23607.2 to 9.0.0-beta.24069.2
- Microsoft.DotNet.GenAPI: from 9.0.0-beta.23607.2 to 9.0.0-beta.24069.2
- Microsoft.DotNet.GenFacades: from 9.0.0-beta.23607.2 to 9.0.0-beta.24069.2
- Microsoft.DotNet.Helix.Sdk: from 9.0.0-beta.23607.2 to 9.0.0-beta.24069.2
- Microsoft.DotNet.PackageTesting: from 9.0.0-beta.23607.2 to 9.0.0-beta.24069.2
- Microsoft.DotNet.RemoteExecutor: from 9.0.0-beta.23607.2 to 9.0.0-beta.24069.2
- Microsoft.DotNet.SharedFramework.Sdk: from 9.0.0-beta.23607.2 to 9.0.0-beta.24069.2
- Microsoft.DotNet.VersionTools.Tasks: from 9.0.0-beta.23607.2 to 9.0.0-beta.24069.2
- Microsoft.DotNet.XliffTasks: from 9.0.0-beta.23607.2 to 9.0.0-beta.24069.2
- Microsoft.DotNet.XUnitAssert: from 9.0.0-beta.23607.2 to 2.6.7-beta.24069.2
- Microsoft.DotNet.XUnitConsoleRunner: from 2.5.3-beta.23607.2 to 2.6.7-beta.24069.2
- Microsoft.DotNet.XUnitExtensions: from 9.0.0-beta.23607.2 to 9.0.0-beta.24069.2

…116.3 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.23607.2 -> To Version 9.0.0-beta.24066.3

ViktorHofer · 2024-01-17T12:20:13Z

Looking at the XUNIT_SPAN related failures.

…116.3 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.23607.2 -> To Version 9.0.0-beta.24066.3

…s://github.com/dotnet/runtime into darc-main-5551d309-34c9-4856-a8f9-48242922b036

ViktorHofer · 2024-01-17T14:48:29Z

@dotnet/source-build-internal can you please help us diagnose the source build issues in this dependency upgrade?

/__w/1/s/artifacts/sb/package-cache/microsoft.dotnet.genfacades/9.0.0-beta.24066.3/build/Microsoft.DotNet.GenFacades.NotSupported.targets(56,5): error MSB4018: The "NotSupportedAssemblyGenerator" task failed unexpectedly. [/__w/1/s/artifacts/sb/src/src/libraries/System.IO.Pipes.AccessControl/src/System.IO.Pipes.AccessControl.csproj::TargetFramework=net9.0]
/__w/1/s/artifacts/sb/package-cache/microsoft.dotnet.genfacades/9.0.0-beta.24066.3/build/Microsoft.DotNet.GenFacades.NotSupported.targets(56,5): error MSB4018: System.BadImageFormatException: Could not load file or assembly 'Microsoft.CodeAnalysis, Version=4.6.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'. Reference assemblies cannot be loaded for execution. (0x80131058) [/__w/1/s/artifacts/sb/src/src/libraries/System.IO.Pipes.AccessControl/src/System.IO.Pipes.AccessControl.csproj::TargetFramework=net9.0]
/__w/1/s/artifacts/sb/package-cache/microsoft.dotnet.genfacades/9.0.0-beta.24066.3/build/Microsoft.DotNet.GenFacades.NotSupported.targets(56,5): error MSB4018: File name: 'Microsoft.CodeAnalysis, Version=4.6.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' ---> System.BadImageFormatException: Could not load file or assembly 'Microsoft.CodeAnalysis, Version=4.6.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL'. Reference assemblies cannot be loaded for execution. (0x80131058) [/__w/1/s/artifacts/sb/src/src/libraries/System.IO.Pipes.AccessControl/src/System.IO.Pipes.AccessControl.csproj::TargetFramework=net9.0]
/__w/1/s/artifacts/sb/package-cache/microsoft.dotnet.genfacades/9.0.0-beta.24066.3/build/Microsoft.DotNet.GenFacades.NotSupported.targets(56,5): error MSB4018: File name: 'Microsoft.CodeAnalysis, Version=4.6.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL' ---> System.BadImageFormatException: Cannot load a reference assembly for execution

mthalman · 2024-01-17T15:53:06Z

I initially suspected that the Microsoft.DotNet.GenFacades package was carrying along a reference assembly version of Microsoft.CodeAnalysis.dll but that isn't the case; it's carrying an implementation assembly. So now the hunt is on to find where this is coming from.

mthalman · 2024-01-17T17:42:12Z

I initially suspected that the Microsoft.DotNet.GenFacades package was carrying along a reference assembly version of Microsoft.CodeAnalysis.dll but that isn't the case; it's carrying an implementation assembly. So now the hunt is on to find where this is coming from.

Ok, I was looking at the wrong package. I needed the SourceBuild intermediates package. So yes, I've confirmed this is coming from the source-built Microsoft.DotNet.GenFacades package. It's pulling in the package from SBRP. I'll investigate further on how to resolve the issue.

mthalman · 2024-01-17T18:02:25Z

This is related to dotnet/source-build-reference-packages#858. Prior to that change, we were getting a prebuilt but it was pulling in the implementation version of Microsoft.CodeAnalysis.dll. Now it's loading it from SBRP because it exists there and getting the reference assembly version. Using the package from SBRP is seemingly the correct thing to do here.

My knowledge on NuGet package authoring isn't all that great. In my mind, it would seem this could be solved by having Microsoft.DotNet.GenFacades have a package reference to Microsoft.CodeAnalysis.CSharp instead of redistributing the DLLs in its own package. But I don't know enough about how to author that. Does that seem like the right thing to do? /cc @MichaelSimons @ViktorHofer @mmitche

ViktorHofer · 2024-01-17T18:05:48Z

MSBuild task packages can't have package references. They need to redistribute their dependencies within the package. Usually msbuild task artifacts are in a folder outside of "lib", i.e. "tools" that NuGet and the SDK ignores.

ViktorHofer · 2024-01-17T18:12:34Z

Looks like this isn't the first time we encounter this issue for GenFacades: dotnet/arcade#13681

We already require a VS 17.8 installation so the version bump shouldn't cause any min version requirement issues. This should unblock dotnet/runtime#97087

ViktorHofer · 2024-01-17T18:18:50Z

While this is an re-occurring issue, I submitted dotnet/arcade#14383 as a workaround to unblock builds meanwhile. We did the same with dotnet/arcade#13681

akoeplinger · 2024-01-19T17:12:48Z

@bradwilson haha yeah good point, we had to reuse a couple deep xunit-internals to get it working on webassembly which can't use threads: https://github.com/dotnet/xharness/blob/fa3b643cc0b028ae875546b7527927adcfcd9348/src/Microsoft.DotNet.XHarness.TestRunners.Xunit/ThreadlessXunitTestRunner.cs#L150

bradwilson · 2024-01-19T17:55:42Z

@akoeplinger The old signature is back in 2.6.7-pre.6

I did mark is as obsolete so people know to use the one that specifies stopOnFail or not, but that should be fine for ABI.

ViktorHofer · 2024-01-19T20:29:21Z

Generating native code
ILC: D:\a_work\1\s\src\coreclr\jit\importercalls.cpp:4106
ILC: Assertion failed '!"Unhandled must expand intrinsic, throwing PlatformNotSupportedException"' in 'System.Type:get_IsPrimitive():ubyte:this' during 'Morph - Inlining' (IL size 7; hash 0x30bca526; FullOpts)

cc @MichalStrehovsky

…119.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.23607.2 -> To Version 9.0.0-beta.24069.2

akoeplinger · 2024-01-21T13:17:00Z

Other variations of that test were already disabled against #84402 so I've disabled building this one too to unblock the PR: #97272

See #97272

They also fail with #97272

This reverts commit 4a6bdb8.

…csproj too" This reverts commit f5729ce.

…bled test" This reverts commit 2267a5c.

MichalStrehovsky · 2024-01-22T05:48:18Z

Other variations of that test were already disabled against #84402 so I've disabled building this one too to unblock the PR: #97272

Thank you - I ended up reverting them because there would be no end to test disabling (it was still not passing and we didn't even try /azp run runtime-nativeaot-outeroop yet). Instead, in 36533db I'm marking Type:get_IsPrimitive as NoOptimization. That should work around. This is a JIT issue that I think will be hittable with tiered PGO in non-AOT scenarios too, we're just lucky to hit it in AOT. The details are in the bug for anyone interested.

MichalStrehovsky · 2024-01-22T07:46:30Z

This is failing in some Tensor tests that are new as of #97192.

Then I see a known failure in S.T.Json, otherwise it's looking good now. Unfortunately the tensor tests are causing quite some noise so I'm not sure that's the extent of it.

akoeplinger · 2024-01-22T08:31:38Z

I think the tensor failures might be due to some xunit changes, I'll take a look locally.

MichalStrehovsky · 2024-01-22T08:33:40Z

I think the tensor failures might be due to some xunit changes, I'll take a look locally.

Double check what I'm saying, but I think we're seeing failures in CI legs that did not trigger for the PR that introduced the tests, so this is probably bad in main.

akoeplinger · 2024-01-22T09:06:49Z

Yeah you're right we're seeing this in main as well.

* Update dependencies from https://github.com/dotnet/arcade build 20240116.3 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.23607.2 -> To Version 9.0.0-beta.24066.3 * Update Versions.props * Make xunit.props respect different versions and assert libraries * Update dependencies from https://github.com/dotnet/arcade build 20240116.3 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.23607.2 -> To Version 9.0.0-beta.24066.3 * Avoid XUNIT_SPAN unambiguous call issues * Disable obsoletion warning for xunit Delegating*Sink * Fix nullable collection test * Fix "DynamicObject_MissingProperty" null test * Remove unnecessary Extensions references * Update dependencies from xharness 9.0.0-prerelease.24066.3 * Try to fix TryCatchFinally test for real * Fix TryCatchFinally for real real * Update dependencies from https://github.com/dotnet/arcade build 20240117.4 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.23607.2 -> To Version 9.0.0-beta.24067.4 * Fix TryCatchFinally for real real real * Update dependencies from https://github.com/dotnet/arcade build 20240118.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.23607.2 -> To Version 9.0.0-beta.24068.1 * Work around Mono issue in AppDomainTests.AssemblyLoad * Update dependencies from https://github.com/dotnet/arcade build 20240118.4 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.23607.2 -> To Version 9.0.0-beta.24068.4 * Update dependencies from https://github.com/dotnet/arcade build 20240119.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.23607.2 -> To Version 9.0.0-beta.24069.2 * Update xunit.props * Update xunit.props * Update dependencies from https://github.com/dotnet/arcade build 20240119.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.23607.2 -> To Version 9.0.0-beta.24069.2 * Disable DisabledRuntimeMarshalling_Disabled_NativeAssemblyEnabled test See dotnet#97272 * Disable AmbiguousImplementationException.ilproj and Pause_ro.csproj too They also fail with dotnet#97272 * Disable Regression2_Regressions.csproj too * Revert "Disable Regression2_Regressions.csproj too" This reverts commit 4a6bdb8. * Revert "Disable AmbiguousImplementationException.ilproj and Pause_ro.csproj too" This reverts commit f5729ce. * Revert "Disable DisabledRuntimeMarshalling_Disabled_NativeAssemblyEnabled test" This reverts commit 2267a5c. * Work around IsPrimitive compilation issue --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com> Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com> Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>

dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jan 17, 2024

This was referenced Jan 17, 2024

[main] Update dependencies from dotnet/arcade #95904

Closed

Remove pinned xunit.analyzers version #97088

Open

ViktorHofer added 2 commits January 17, 2024 11:19

Update Versions.props

6c4130a

Make xunit.props respect different versions and assert libraries

f1813c8

dotnet-maestro bot and others added 3 commits January 17, 2024 13:06

Avoid XUNIT_SPAN unambiguous call issues

51646af

Merge branch 'darc-main-5551d309-34c9-4856-a8f9-48242922b036' of http…

1b7d1e5

…s://github.com/dotnet/runtime into darc-main-5551d309-34c9-4856-a8f9-48242922b036

build-analysis bot mentioned this pull request Jan 17, 2024

Test failure - System.NullReferenceException in System.Threading.Lock.TryInitializeStatics #94728

Closed

ViktorHofer mentioned this pull request Jan 17, 2024

Add S.C.I. and S.R.M. dependencies dotnet/arcade#14377

Merged

Disable obsoletion warning for xunit Delegating*Sink

2aab1e2

build-analysis bot mentioned this pull request Jan 17, 2024

NuGet failing with Response status code does not indicate success: 503 (Service Unavailable) dotnet/arcade#11723

Open

5 tasks

ViktorHofer added a commit to dotnet/arcade that referenced this pull request Jan 17, 2024

Update CodeAnalysis to 4.8.0

5ead4ba

We already require a VS 17.8 installation so the version bump shouldn't cause any min version requirement issues. This should unblock dotnet/runtime#97087

ViktorHofer mentioned this pull request Jan 17, 2024

Update CodeAnalysis to 4.8.0 dotnet/arcade#14383

Merged

ViktorHofer added 3 commits January 17, 2024 18:35

Fix nullable collection test

ebfd0cb

Fix "DynamicObject_MissingProperty" null test

dd3ac47

Remove unnecessary Extensions references

00e9a4c

dotnet-maestro bot requested a review from lewing as a code owner January 17, 2024 19:18

ViktorHofer approved these changes Jan 19, 2024

View reviewed changes

ViktorHofer added 2 commits January 19, 2024 19:10

Update xunit.props

913a970

Update xunit.props

e68e737

akoeplinger added area-codeflow for labeling automated codeflow and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jan 19, 2024

Merge branch 'main' into darc-main-5551d309-34c9-4856-a8f9-48242922b036

ec3f6b2

akoeplinger mentioned this pull request Jan 21, 2024

Assertion failed '!"Unhandled must expand intrinsic, throwing PlatformNotSupportedException"' in Checked mode #97272

Closed

Disable DisabledRuntimeMarshalling_Disabled_NativeAssemblyEnabled test

2267a5c

See #97272

akoeplinger force-pushed the darc-main-5551d309-34c9-4856-a8f9-48242922b036 branch from ed54bff to 2267a5c Compare January 21, 2024 15:14

akoeplinger and others added 6 commits January 21, 2024 18:29

Disable AmbiguousImplementationException.ilproj and Pause_ro.csproj too

f5729ce

They also fail with #97272

Disable Regression2_Regressions.csproj too

4a6bdb8

Revert "Disable Regression2_Regressions.csproj too"

464babf

This reverts commit 4a6bdb8.

Revert "Disable AmbiguousImplementationException.ilproj and Pause_ro.…

5967c84

…csproj too" This reverts commit f5729ce.

Revert "Disable DisabledRuntimeMarshalling_Disabled_NativeAssemblyEna…

8f2d412

…bled test" This reverts commit 2267a5c.

Work around IsPrimitive compilation issue

36533db

MichalStrehovsky mentioned this pull request Jan 22, 2024

Add lots more TensorPrimitives operations #97192

Merged

ViktorHofer merged commit 8726d6b into main Jan 22, 2024
187 of 194 checks passed

ViktorHofer deleted the darc-main-5551d309-34c9-4856-a8f9-48242922b036 branch January 22, 2024 10:13

github-actions bot locked and limited conversation to collaborators Feb 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[main] Update dependencies from dotnet/arcade #97087

[main] Update dependencies from dotnet/arcade #97087

dotnet-maestro bot commented Jan 17, 2024 •

edited

Loading

ViktorHofer commented Jan 17, 2024

ViktorHofer commented Jan 17, 2024

mthalman commented Jan 17, 2024 •

edited

Loading

mthalman commented Jan 17, 2024

mthalman commented Jan 17, 2024

ViktorHofer commented Jan 17, 2024

ViktorHofer commented Jan 17, 2024

ViktorHofer commented Jan 17, 2024

akoeplinger commented Jan 19, 2024

bradwilson commented Jan 19, 2024 •

edited

Loading

ViktorHofer commented Jan 19, 2024

akoeplinger commented Jan 21, 2024 •

edited

Loading

MichalStrehovsky commented Jan 22, 2024

MichalStrehovsky commented Jan 22, 2024

akoeplinger commented Jan 22, 2024

MichalStrehovsky commented Jan 22, 2024

akoeplinger commented Jan 22, 2024 •

edited

Loading

[main] Update dependencies from dotnet/arcade #97087

[main] Update dependencies from dotnet/arcade #97087

Conversation

dotnet-maestro bot commented Jan 17, 2024 • edited Loading

From https://github.com/dotnet/arcade

ViktorHofer commented Jan 17, 2024

ViktorHofer commented Jan 17, 2024

mthalman commented Jan 17, 2024 • edited Loading

mthalman commented Jan 17, 2024

mthalman commented Jan 17, 2024

ViktorHofer commented Jan 17, 2024

ViktorHofer commented Jan 17, 2024

ViktorHofer commented Jan 17, 2024

akoeplinger commented Jan 19, 2024

bradwilson commented Jan 19, 2024 • edited Loading

ViktorHofer commented Jan 19, 2024

akoeplinger commented Jan 21, 2024 • edited Loading

MichalStrehovsky commented Jan 22, 2024

MichalStrehovsky commented Jan 22, 2024

akoeplinger commented Jan 22, 2024

MichalStrehovsky commented Jan 22, 2024

akoeplinger commented Jan 22, 2024 • edited Loading

dotnet-maestro bot commented Jan 17, 2024 •

edited

Loading

mthalman commented Jan 17, 2024 •

edited

Loading

bradwilson commented Jan 19, 2024 •

edited

Loading

akoeplinger commented Jan 21, 2024 •

edited

Loading

akoeplinger commented Jan 22, 2024 •

edited

Loading