Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable dump creation for ParallelCrashTester child #97095

Merged

Conversation

janvorli
Copy link
Member

The child process is intentionally crashing, so creating a dump for it is a waste of time and disk space and it also seems to be causing random failures of the test in the CI.

This change disables the dump creation for it.

Close #94652

The child process is intentionally crashing, so creating a dump for it
is a waste of time and disk space and it also seems to be causing random
failures of the test in the CI.

This change disables the dump creation for it.
@janvorli janvorli added this to the 9.0.0 milestone Jan 17, 2024
@janvorli janvorli requested a review from trylek January 17, 2024 13:14
@janvorli janvorli self-assigned this Jan 17, 2024
@janvorli
Copy link
Member Author

/azp run runtime-coreclr outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@janvorli janvorli merged commit 8c73f0f into dotnet:main Jan 19, 2024
163 of 166 checks passed
@janvorli janvorli deleted the prevent-parallelcrashtester-child-dump branch January 19, 2024 13:28
tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024
The child process is intentionally crashing, so creating a dump for it
is a waste of time and disk space and it also seems to be causing random
failures of the test in the CI.

This change disables the dump creation for it.
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure: _ParallelCrashTester::ParallelCrashTester.ParallelCrashMainThread()
3 participants