Fold GeneratingMetadataManager into MetadataManager #97140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Long time ago, `MetadataManager` had two descendants: the `GeneratingMetadataManager` and another one that I forgot the name of. It was used for .NET Native and didn't generate metadata, because ILTransforms did. Fold the classes together.
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsLong time ago, Fold the classes together. Cc @dotnet/ilc-contrib
|
ghost
assigned
This was referenced Jan 18, 2024
jkotas
approved these changes
Jan 18, 2024
tmds
pushed a commit
to tmds/runtime
that referenced
this pull request
Jan 23, 2024
Long time ago, `MetadataManager` had two descendants: the `GeneratingMetadataManager` and another one that I forgot the name of. It was used for .NET Native and didn't generate metadata, because ILTransforms did. Fold the classes together.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long time ago,
MetadataManagerhad two descendants: theGeneratingMetadataManagerand another one that I forgot the name of. It was used for .NET Native and didn't generate metadata, because ILTransforms did.Fold the classes together.
Cc @dotnet/ilc-contrib