Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade version of BinLogToSln #97173

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

agocke
Copy link
Member

@agocke agocke commented Jan 18, 2024

No description provided.

@ghost ghost assigned agocke Jan 18, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jan 18, 2024
@steveisok steveisok self-requested a review January 18, 2024 19:32
@agocke
Copy link
Member Author

agocke commented Jan 18, 2024

Merging as I already created and tested an official build with this change.

@agocke agocke merged commit fae3b88 into dotnet:main Jan 18, 2024
8 of 14 checks passed
@agocke agocke deleted the upgrade-source-index branch January 18, 2024 19:33
@ViktorHofer
Copy link
Member

You are changing an eng/common file. This should go into Arcade.

@MichalStrehovsky
Copy link
Member

Merging as I already created and tested an official build with this change.

I saw the build but it doesn't look like it executed this leg. Official builds are still failing with a missing package (now there's an extra 1). I have #97196 that cherry picks the version change from the Arcade update PR that is currently blocked.

tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants