-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JIT: Skip BBJ_CALLFINALLYRET
in BasicBlock::VisitEHSuccs
#97184
Conversation
We currently skip yielding EH successors of BBJ_CALLFINALLYRET nodes in `BasicBlock::VisitAllSuccs`. `BasicBlock::VisitEHSuccs` should be consistent with this.
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsWe currently skip yielding EH successors of BBJ_CALLFINALLYRET nodes in Minor diffs from differences in PHI placement expected.
|
cc @dotnet/jit-contrib PTAL @BruceForstall Diffs. Surprisingly large on win-x86. |
Can you characterize why? I saw a few cases of no longer reloading a register before a tailcall. |
Those are Also saw some GC info diffs; going to run some stress just to be safe. |
/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, runtime-coreclr gcstress0x3-gcstress0xc |
Azure Pipelines successfully started running 3 pipeline(s). |
…97184) We currently skip yielding EH successors of BBJ_CALLFINALLYRET nodes in `BasicBlock::VisitAllSuccs`. `BasicBlock::VisitEHSuccs` should be consistent with this.
We currently skip yielding EH successors of BBJ_CALLFINALLYRET nodes in
BasicBlock::VisitAllSuccs
.BasicBlock::VisitEHSuccs
should be consistent with this.Minor diffs from differences in PHI placement expected.