Fix mscordac exports #97210
Closed
Fix mscordac exports #97210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mscordbi depends on the PAL in mscordac and so it requires that all functions it uses from coreclr PAL are exported by the libmscordac. This got broken recently by a change in a header consumed by the mscordbi that pulled in usage of two functions for UTF16 to UTF8 conversion into the mscordbi. This issue prevents debuggers using libmscordbi to initiate debugging. This change fixes it by exporting those two functions from libmscordac.
|
Tagging subscribers to this area: @tommcdon Issue DetailsThe mscordbi depends on the PAL in mscordac and so it requires that all functions it uses from coreclr PAL are exported by the libmscordac. This got broken recently by a change in a header consumed by the mscordbi that pulled in usage of two functions for UTF16 to UTF8 conversion into the mscordbi (#96099). This issue prevents debuggers using libmscordbi to initiate debugging. This change fixes it by exporting those two functions from libmscordac.
|
|
I believe this should have been fixed on #97055. Cc @hoyosjs @mikem8361 |
|
Hmm, I've not noticed that change, it seems to work fine. I'm closing this PR then. |
This was referenced Jan 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mscordbi depends on the PAL in mscordac and so it requires that all functions it uses from coreclr PAL are exported by the libmscordac. This got broken recently by a change in a header consumed by the mscordbi that pulled in usage of two functions for UTF16 to UTF8 conversion into the mscordbi (#96099).
This issue prevents debuggers using libmscordbi to initiate debugging.
This change fixes it by exporting those two functions from libmscordac.