-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JIT: Remove old loop code #97232
JIT: Remove old loop code #97232
Conversation
All dependencies on old loop finding have been removed, so remove all old code associated with it.
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsAll dependencies on old loop finding have been removed, so remove all old code associated with it. No diffs expected. Some TP improvements expected from removing old loop finding and from removing a DFS of the flow graph.
|
No asm diffs; significant TP improvements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on getting this far so quickly!
@@ -4737,412 +4677,18 @@ void Compiler::fgDebugCheckSsa() | |||
// | |||
void Compiler::fgDebugCheckLoopTable() | |||
{ | |||
if ((m_loops != nullptr) && optLoopsRequirePreHeaders) | |||
if (m_loops == nullptr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the header comment above needs to be updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Also rephrased a few other things (removed references to "loop table") and deleted the loop flag enum that had been left over.
cc @dotnet/jit-contrib |
Thanks! There's still some regressions to investigate, but overall I'm happy with how this ended up, and now I have a very good understanding of how all the pieces fit together :-) |
All dependencies on old loop finding have been removed, so remove all old code associated with it.
All dependencies on old loop finding have been removed, so remove all old code associated with it.
No diffs expected. Some TP improvements expected from removing old loop finding and from removing a DFS of the flow graph.