Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: Remove old loop code #97232

Merged
merged 5 commits into from
Jan 22, 2024
Merged

Conversation

jakobbotsch
Copy link
Member

All dependencies on old loop finding have been removed, so remove all old code associated with it.

No diffs expected. Some TP improvements expected from removing old loop finding and from removing a DFS of the flow graph.

All dependencies on old loop finding have been removed, so remove all
old code associated with it.
@ghost ghost assigned jakobbotsch Jan 19, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 19, 2024
@ghost
Copy link

ghost commented Jan 19, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

All dependencies on old loop finding have been removed, so remove all old code associated with it.

No diffs expected. Some TP improvements expected from removing old loop finding and from removing a DFS of the flow graph.

Author: jakobbotsch
Assignees: jakobbotsch
Labels:

area-CodeGen-coreclr

Milestone: -

@BruceForstall
Copy link
Member

Diffs

No asm diffs; significant TP improvements.

Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on getting this far so quickly!

@@ -4737,412 +4677,18 @@ void Compiler::fgDebugCheckSsa()
//
void Compiler::fgDebugCheckLoopTable()
{
if ((m_loops != nullptr) && optLoopsRequirePreHeaders)
if (m_loops == nullptr)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the header comment above needs to be updated?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Also rephrased a few other things (removed references to "loop table") and deleted the loop flag enum that had been left over.

@jakobbotsch
Copy link
Member Author

cc @dotnet/jit-contrib

@jakobbotsch
Copy link
Member Author

Congrats on getting this far so quickly!

Thanks! There's still some regressions to investigate, but overall I'm happy with how this ended up, and now I have a very good understanding of how all the pieces fit together :-)

@jakobbotsch jakobbotsch merged commit 205ef03 into dotnet:main Jan 22, 2024
129 checks passed
@jakobbotsch jakobbotsch deleted the remove-old-loops branch January 22, 2024 09:31
tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024
All dependencies on old loop finding have been removed, so remove all
old code associated with it.
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants