Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash code tests cleanup #97299

Merged
merged 11 commits into from
Jan 25, 2024
Merged

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Jan 22, 2024

Moving tests around after #96354 and before PR with new SortKey tests. We have a bunch of mixed - purpose tests in CompareInfoTests.cs that can be categorized as SortKey or HashCode. This PR:

  • moves tests to files according to their category,
  • removes non-necessary comments,
  • removes duplicated test data (for en-GB)
  • adds yield return new object[] { s_invariantCompare, "igloo", "\u0130GLOO", CompareOptions.None }; case, we did not test None at all previously.,
  • enables a few tests that were fixed by Limit PNSE by using Invariant HashCode in HybridGlobalization #96354.

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-System.Globalization test-enhancement Improvements of test source code labels Jan 22, 2024
@ilonatommy ilonatommy self-assigned this Jan 22, 2024
@ghost
Copy link

ghost commented Jan 22, 2024

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Moving tests around after #96354 and before PR with new SortKey tests. We have a bunch of mixed - purpose tests in CompareInfoTests.cs that can be categorized as SortKey or HashCode. This PR:

  • moves tests to files according to their category,
  • removes non-necessary comments,
  • removes duplicated test data (for en-GB)
  • adds yield return new object[] { s_invariantCompare, "igloo", "\u0130GLOO", CompareOptions.None }; case, we did not test None at all previously.
Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm, area-System.Globalization, test-enhancement

Milestone: -

@ilonatommy ilonatommy marked this pull request as draft January 22, 2024 12:28
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy ilonatommy marked this pull request as ready for review January 22, 2024 20:26
@ilonatommy ilonatommy requested a review from mkhamoyan January 22, 2024 20:26
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy
Copy link
Member Author

/azp run runtime-wasm-libtests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy ilonatommy merged commit 75dc1b3 into dotnet:main Jan 25, 2024
117 of 125 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Globalization test-enhancement Improvements of test source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants