Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser][MT] Enable DerivedCancellationTokenSource, AbandonExisting #97545

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Jan 26, 2024

Fixes #94486 #91547.

Cannot reproduce locally (1k trials on repeat), enabling to test on CI.

@ilonatommy ilonatommy added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) arch-wasm WebAssembly architecture area-VM-threading-mono labels Jan 26, 2024
@ilonatommy ilonatommy self-assigned this Jan 26, 2024
@ghost
Copy link

ghost commented Jan 26, 2024

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #94486.

Cannot reproduce locally, enabling to test on CI.

Author: ilonatommy
Assignees: ilonatommy
Labels:

NO-MERGE, arch-wasm, area-VM-threading-mono

Milestone: -

@ilonatommy
Copy link
Member Author

/azp run runtime-wasm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy
Copy link
Member Author

/azp run runtime-wasm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy ilonatommy changed the title [browser][MT] Enable DerivedCancellationTokenSource [browser][MT] Enable DerivedCancellationTokenSource, AbandonExisting Jan 26, 2024
@ilonatommy ilonatommy marked this pull request as ready for review January 26, 2024 17:20
@pavelsavara
Copy link
Member

let's give it one mode chance to timeout

@pavelsavara
Copy link
Member

/azp run runtime-wasm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy ilonatommy removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Jan 27, 2024
@ilonatommy
Copy link
Member Author

let's give it one more chance to timeout

everything good

@ilonatommy ilonatommy merged commit 7caed53 into dotnet:main Jan 30, 2024
132 of 137 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-VM-threading-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[browser][MT] CancellationTokenTests.DerivedCancellationTokenSource
2 participants