-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser][MT] Enable DerivedCancellationTokenSource
, AbandonExisting
#97545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilonatommy
added
NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
arch-wasm
WebAssembly architecture
area-VM-threading-mono
labels
Jan 26, 2024
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
ilonatommy
changed the title
[browser][MT] Enable
[browser][MT] Enable Jan 26, 2024
DerivedCancellationTokenSource
DerivedCancellationTokenSource
, AbandonExisting
This was referenced Jan 26, 2024
let's give it one mode chance to timeout |
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
ilonatommy
removed
the
NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
label
Jan 27, 2024
everything good |
pavelsavara
approved these changes
Jan 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94486 #91547.
Cannot reproduce locally (1k trials on repeat), enabling to test on CI.