Replace SPKI hashing with a managed implementation #97559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones Issue DetailsThis gets rid of the pinvoke to
|
vcsjones
commented
Jan 26, 2024
...raphy/src/System/Security/Cryptography/X509Certificates/X509SubjectKeyIdentifierExtension.cs
Show resolved
Hide resolved
This was referenced Jan 26, 2024
bartonjs
approved these changes
Jan 27, 2024
This was referenced Jan 29, 2024
Closed
This was referenced Jan 29, 2024
|
Test failures are known. Merging. |
bartonjs
added
cryptographic-docs-impact
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of the pinvoke to
CryptHashPublicKeyInfoand replaces the implementation with a managed one since we needed it anyway for non-Windows platforms. Since the implementation would be the same for Windows/non-Windows, we can get rid of it from the X.509 PAL.