Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] improve behavior after exit, better docs #97651

Merged
merged 23 commits into from
Jan 31, 2024
Merged

[browser] improve behavior after exit, better docs #97651

merged 23 commits into from
Jan 31, 2024

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Jan 29, 2024 •
edited
Loading

  • exit assert message to log
  • browser template doesn't exit by default
  • improved docs

Fixes #94906

@pavelsavara
- better API and exit assert
2cc5cd1 
 - browser template doesn't exit
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Jan 29, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Jan 29, 2024
@pavelsavara pavelsavara self-assigned this Jan 29, 2024
@ghost
Copy link

ghost commented Jan 29, 2024

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • better API and exit assert
  • browser template doesn't exit by default

Fixes #94906

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser
Milestone: 9.0.0

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@pavelsavara pavelsavara marked this pull request as ready for review January 29, 2024 18:43
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jan 29, 2024
Closed
Closed
maraf
maraf reviewed Jan 30, 2024
View reviewed changes
Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions, not that I'm an expert here

src/mono/browser/runtime/dotnet.d.ts Outdated Show resolved Hide resolved
src/mono/browser/runtime/dotnet.d.ts Outdated Show resolved Hide resolved
src/mono/browser/runtime/dotnet.d.ts Show resolved Hide resolved
src/mono/browser/runtime/dotnet.d.ts Outdated Show resolved Hide resolved
src/mono/browser/runtime/dotnet.d.ts Outdated Show resolved Hide resolved
src/mono/browser/runtime/dotnet.d.ts Outdated Show resolved Hide resolved
src/mono/browser/runtime/dotnet.d.ts Outdated Show resolved Hide resolved
src/mono/browser/runtime/dotnet.d.ts Outdated Show resolved Hide resolved
src/mono/browser/runtime/loader/exit.ts Outdated Show resolved Hide resolved
src/mono/browser/runtime/loader/exit.ts Outdated Show resolved Hide resolved
pavelsavara and others added 13 commits January 30, 2024 11:55
@pavelsavara @maraf
Update src/mono/browser/runtime/dotnet.d.ts
0a633b3 
Co-authored-by: Marek Fišera <mara@neptuo.com>
@pavelsavara @maraf
Update src/mono/browser/runtime/dotnet.d.ts
0643bc0 
Co-authored-by: Marek Fišera <mara@neptuo.com>
@pavelsavara @maraf
Update src/mono/browser/runtime/dotnet.d.ts
0fa7ff3 
Co-authored-by: Marek Fišera <mara@neptuo.com>
@pavelsavara @maraf
Update src/mono/browser/runtime/dotnet.d.ts
1523802 
Co-authored-by: Marek Fišera <mara@neptuo.com>
@pavelsavara @maraf
Update src/mono/browser/runtime/dotnet.d.ts
6f9b4f1 
Co-authored-by: Marek Fišera <mara@neptuo.com>
@pavelsavara @maraf
Update src/mono/browser/runtime/dotnet.d.ts
692b1b3 
Co-authored-by: Marek Fišera <mara@neptuo.com>
@pavelsavara @maraf
Update src/mono/browser/runtime/dotnet.d.ts
deffd52 
Co-authored-by: Marek Fišera <mara@neptuo.com>
@pavelsavara @maraf
Update src/mono/browser/runtime/dotnet.d.ts
8b90dd7 
Co-authored-by: Marek Fišera <mara@neptuo.com>
@pavelsavara @maraf
Update src/mono/browser/runtime/dotnet.d.ts
d92d820 
Co-authored-by: Marek Fišera <mara@neptuo.com>
@pavelsavara @maraf
Update src/mono/browser/runtime/dotnet.d.ts
6cd8dd8 
Co-authored-by: Marek Fišera <mara@neptuo.com>
@pavelsavara @maraf
Update src/mono/browser/runtime/loader/exit.ts
2fc30ac 
Co-authored-by: Marek Fišera <mara@neptuo.com>
@pavelsavara @maraf
Update src/mono/browser/runtime/loader/exit.ts
7e487d9 
Co-authored-by: Marek Fišera <mara@neptuo.com>
@pavelsavara @maraf
Update src/mono/browser/runtime/dotnet.d.ts
ad07814 
Co-authored-by: Marek Fišera <mara@neptuo.com>
@pavelsavara @maraf
Update src/mono/browser/runtime/dotnet.d.ts
e3e516e 
Co-authored-by: Marek Fišera <mara@neptuo.com>
@build-analysis build-analysis bot mentioned this pull request Jan 30, 2024
Closed
@lewing lewing merged commit c9a1eb4 into dotnet:main Jan 31, 2024
36 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2024
@pavelsavara pavelsavara deleted the browser_after_exit branch September 2, 2024 15:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maraf maraf maraf approved these changes

@ilonatommy ilonatommy Awaiting requested review from ilonatommy ilonatommy is a code owner

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

[browser] improve behavior after exit
3 participants
@pavelsavara @maraf @lewing