Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NativeAOT/ARM] Fix RhpLockCmpXchg16 #97743

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

filipnavara
Copy link
Member

Fixes #97730

Zero-extend comparand parameter of RhpLockCmpXchg16 to match the managed prototype which uses signed type argument and is thus sign extended in the register. Conversely, sign extend the return value.

prototype which uses signed type argument and is thus sign extended.
Conversely, sign extend the return value.
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jan 31, 2024
@filipnavara filipnavara added arch-arm32 and removed community-contribution Indicates that the PR has been added by a community member labels Jan 31, 2024
@ghost
Copy link

ghost commented Jan 31, 2024

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #97730

Zero-extend comparand parameter of RhpLockCmpXchg16 to match the managed prototype which uses signed type argument and is thus sign extended in the register. Conversely, sign extend the return value.

Author: filipnavara
Assignees: -
Labels:

area-NativeAOT-coreclr

Milestone: -

@jkotas jkotas merged commit 32db100 into dotnet:main Jan 31, 2024
107 of 110 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NativeAOT/ARM] Interlocked tests fail
2 participants