Remove strtok, strtok_s, wcstok_s PAL APIs #98008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9cf7d84.
…nstead of wcstok_s.
ghost
assigned
This was referenced Feb 6, 2024
jkotas
reviewed
Feb 6, 2024
…to avoid heap allocations
3 tasks
jkotas
reviewed
Feb 6, 2024
src/coreclr/vm/profilinghelper.cpp
Outdated
|
|
||
| PathString path{profilerList, sectionStart, pathEnd}; | ||
| StackSString clsidString{profilerList, clsidStart, sectionEnd}; | ||
| NewArrayHolder<WCHAR> clsidStringRaw = clsidString.GetCopyOfUnicodeString(); |
There was a problem hiding this comment.
Suggested change
| NewArrayHolder<WCHAR> clsidStringRaw = clsidString.GetCopyOfUnicodeString(); |
jkotas
reviewed
Feb 6, 2024
src/coreclr/vm/profilinghelper.cpp
Outdated
| CLSID clsid; | ||
| hr = ProfilingAPIUtility::ProfilerCLSIDFromString(currentGuid, &clsid); | ||
| hr = ProfilingAPIUtility::ProfilerCLSIDFromString(clsidStringRaw, &clsid); |
There was a problem hiding this comment.
Suggested change
| hr = ProfilingAPIUtility::ProfilerCLSIDFromString(clsidStringRaw, &clsid); | |
| hr = ProfilingAPIUtility::ProfilerCLSIDFromString(clsidString.GetUnicode(), &clsid); |
?
3 tasks
|
@dotnet-policy-service rerun |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These APIs were used extremely rarely throughout CoreCLR (one usage each), so replace the usages with platform-native APIs (strtok_r for strtok and strtok_s) or use SString to hand-roll the one usage (for wcstok_s).