-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser] remove memory snapshot feature #98093
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
WebAssembly architecture
os-browser
Browser variant of arch-wasm
labels
Feb 7, 2024
dotnet-issue-labeler
bot
added
the
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
label
Feb 7, 2024
Tagging subscribers to 'arch-wasm': @lewing Issue Detailssnapshot of WASM linear memory into browser cache was interesting experiment.
For now, it greatly complicates startup and brings extra test scenarios and maintenance.
|
pavelsavara
added
area-System.Runtime.InteropServices.JavaScript
and removed
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
Feb 7, 2024
maraf
approved these changes
Feb 7, 2024
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
lewing
approved these changes
Feb 7, 2024
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Feb 7, 2024
Closed
I filled #98145 |
This was referenced Feb 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
arch-wasm
WebAssembly architecture
area-System.Runtime.InteropServices.JavaScript
os-browser
Browser variant of arch-wasm
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
snapshot of WASM linear memory into browser cache was interesting experiment.
Unfortunately it doesn't add significant benefits
fetch
cache. Probably because it's too large block of memory and we hit disk IO.For now, it greatly complicates startup and brings extra test scenarios and maintenance.