Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser] remove memory snapshot feature #98093

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

pavelsavara
Copy link
Member

snapshot of WASM linear memory into browser cache was interesting experiment.
Unfortunately it doesn't add significant benefits

  • load of multiple MB from browser cache is not faster than instantiating the same DLLs from fetch cache. Probably because it's too large block of memory and we hit disk IO.
  • downloading the memory would be very large too.
  • going forward, we could return to this and try to include it into .wasm file during build.

For now, it greatly complicates startup and brings extra test scenarios and maintenance.

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture os-browser Browser variant of arch-wasm labels Feb 7, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Feb 7, 2024
@pavelsavara pavelsavara requested a review from maraf February 7, 2024 13:41
@pavelsavara pavelsavara self-assigned this Feb 7, 2024
@pavelsavara pavelsavara requested a review from lewing as a code owner February 7, 2024 13:41
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 7, 2024
@ghost
Copy link

ghost commented Feb 7, 2024

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

snapshot of WASM linear memory into browser cache was interesting experiment.
Unfortunately it doesn't add significant benefits

  • load of multiple MB from browser cache is not faster than instantiating the same DLLs from fetch cache. Probably because it's too large block of memory and we hit disk IO.
  • downloading the memory would be very large too.
  • going forward, we could return to this and try to include it into .wasm file during build.

For now, it greatly complicates startup and brings extra test scenarios and maintenance.

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, os-browser

Milestone: 9.0.0

@pavelsavara pavelsavara added area-System.Runtime.InteropServices.JavaScript and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Feb 7, 2024
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

I filled #98145

@pavelsavara pavelsavara merged commit 607c1bf into dotnet:main Feb 8, 2024
129 of 140 checks passed
@pavelsavara pavelsavara deleted the browser_remove_snapshot branch February 8, 2024 07:40
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants