Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new MacOS arm64 pool for official builds #98117

Merged
merged 4 commits into from
Feb 29, 2024
Merged

Use new MacOS arm64 pool for official builds #98117

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
530f442
Use new MacOS arm64 pool for official builds
Feb 7, 2024
fc5e3ef
Merge remote-tracking branch 'upstream/main' into use-faster-better-macs
Feb 12, 2024
432eb1f
Add workaround from https://github.com/dotnet/runtime/pull/97856 to u…
Feb 12, 2024
afcf465
Merge branch 'main' into use-faster-better-macs
jkotas Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion eng/pipelines/common/xplat-setup.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,9 +171,13 @@ jobs:
demands: ImageOverride -equals Build.Ubuntu.2204.Amd64

# OSX Build Pool (we don't have on-prem OSX BuildPool).
${{ if in(parameters.osGroup, 'osx', 'maccatalyst', 'ios', 'iossimulator', 'tvos', 'tvossimulator') }}:
${{ if and(in(parameters.osGroup, 'osx', 'maccatalyst', 'ios', 'iossimulator', 'tvos', 'tvossimulator'), eq(variables['System.TeamProject'], 'public')) }}:
vmImage: 'macos-12'

# Official build OSX pool
${{ if and(in(parameters.osGroup, 'osx', 'maccatalyst', 'ios', 'iossimulator', 'tvos', 'tvossimulator'), ne(variables['System.TeamProject'], 'public')) }}:
vmImage: 'macos-13-arm64'
Copy link
Member

@jkotas jkotas Feb 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should double check that these builds use native Arm64 SDK after the switch.

(x64 SDK running on Arm64 emulator is slow and it has reliability issues.)


# Official Build Windows Pool
${{ if and(or(eq(parameters.osGroup, 'windows'), eq(parameters.jobParameters.hostedOs, 'windows')), ne(variables['System.TeamProject'], 'public')) }}:
name: $(DncEngInternalBuildPool)
Expand Down
Loading