Added more verbose error message when calling method using reflection and target type does not match passed type

[AndyBevan]

Added more verbose error message when calling method using reflection and target type does not match passed type (fixes #97022)

[ghost]

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Added more verbose error message when calling method using reflection and target type does not match passed type (fixes #97022)

Author:	AndyBevan
Assignees:	-
Labels:	area-System.Reflection
Milestone:	-

[AndyBevan]

This fails on Linux but passes locally for me? I'm guessing I missed something somewhere because the test results I found are still showing the original error message. Hoping someone can offer me a pointer on what I missed. Thanks

https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-98129-merge-bd36d088b19a4bdcad/System.Reflection.Tests/1/console.faa125c0.log?helixlogtype=result
[FAIL] System.Reflection.Tests.DefaultBinderTests.InvokeWithIncorrectTargetTypeThrowsCorrectException Assert.Equal() Failure: Strings differ ↓ (pos 7) Expected: "Object of type Test does not match target"··· Actual: "Object does not match target type." ↑ (pos 7) at System.Reflection!<BaseAddress>+0xb067e0 at System.Reflection.DynamicInvokeInfo.Invoke(Object, IntPtr, Object[], BinderBundle, Boolean) + 0xbc

[AndyBevan]

Thanks @danmoseley for your PR review - I've now fixed the test failure. I did have a few questions related to working on the dotnet runtime in the related issue - #97022 (comment) - if you had time to help with answers that would be fantastic and it would help my understanding of how things fit together.

[danmoseley]

Hi @AndyBevan this isn't my code area. @steveharter is it possible for you to give @AndyBevan the necessary pointers and help get this signed off?

[AndyBevan]

I think everything is now resolved and tests now pass.

@danmoseley / @buyaa-n - would one of you be able to point me to instructions on how I would run the AOT version of the tests locally - ideally so I can debug them in Visual Studio - I had to make a lucky guess on the AOT version as I couldn't test it locally. I looked at what helix logs and I don't see a way to runt his locally >call RunTests.cmd --runtime-path C:\h\w\C3860A44\p

[buyaa-n]

Tests did not run on CI because the branch was needed to be merged with latest, I clicked the merge button, now we will see if test fails

would one of you be able to point me to instructions on how I would run the AOT version of the tests locally

I have never run tests on AOT, according to the doc seems its need to be build with libs+clr.aot option and then run tests dotnet build -c Release -t:Test -p:TestNativeAot=true, though this would run all tests which would take too much time, better to move to the Runtime tests folder and run the test:
cd src\libraries\System.Runtime\tests
dotnet build /t:Test /p:TestNativeAot=true

[AndyBevan]

Thanks so much @buyaa-n for doing that, also thanks for explaining to me how to run those AOT tests, this is a new area for me. Is there a way to run the AOT tests through visual studio?

Also - the tests seemed to fail for some javascript related problems. I'll update the branch with the latest from main and see if they pass on a second run.

[buyaa-n]

Is there a way to run the AOT tests through visual studio?

Do not know for sure, do might help: https://github.com/dotnet/runtime/blob/main/src/coreclr/nativeaot/docs/debugging.md

[buyaa-n]

LGMT, thank you!

Failures unrelated and known

[danmoseley]

thanks @AndyBevan !