Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0-staging] Define installer-owned directories in dotnet-runtime RPM package #98244

Conversation

NikolaMilosavljevic
Copy link
Member

@NikolaMilosavljevic NikolaMilosavljevic commented Feb 9, 2024

Backport of #97183 to release/7.0-staging

Customer Impact

  • Customer reported
  • Found internally

dotner-runtime RPM package does not define any directories it owns. This causes versioned directory to be left on the machine after uninstall or package upgrade. Presence of the old directory triggers S360 warning about unsecure, stale .NET version.

There are no issues with other .NET packages - dotnet-hostfxr and aspnetcore-runtime packages contain versioned directories which are properly deleted on package uninstall or upgrade.

Regression

  • Yes
  • No

Not a regression - the issue always existed.

Testing

Built a private package with the fix and tested on Mariner 2.0.

Risk

Low. Already tested and present in 9.0.

@NikolaMilosavljevic NikolaMilosavljevic added the Servicing-consider Issue for next servicing release review label Feb 9, 2024
@NikolaMilosavljevic
Copy link
Member Author

OSX job timed out - it seems to be a frequent failure in other PRs. This change is Linux-specific.

@NikolaMilosavljevic NikolaMilosavljevic merged commit 828f413 into dotnet:release/7.0-staging Feb 11, 2024
87 of 94 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Setup Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants