-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser][MT] preparation for deputy #98298
Conversation
- pass TID to InstallMainSynchronizationContext and GCHandle back - don't use synchronous resolve for Tasks pre-resolved on another thread - fix CTS leak in WaitAssertsOnJSInteropThreads - rename mono_wasm_invoke_method_bound to mono_wasm_invoke_method - drop mono_wasm_invoke_method_raw in favor of mono_wasm_invoke_method - load segmentation-rules and symbols into worker - normalized functions in managed-exports.ts - renamed runtimeHelpers.proxyGCHandle - handle exit_code === undefined - handle document undefined in appendElementOnExit (worker) - made loaderHelpers.invariantMode local variable - improved thread dump for detached threads and UI thread - mono_wasm_init_threads asynchronously and earlier and moved the code - moved more logic into start_runtime() -
Tagging subscribers to 'arch-wasm': @lewing Issue Details
|
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not spot anything ungood
...aScript/src/System/Runtime/InteropServices/JavaScript/Marshaling/JSMarshalerArgument.Task.cs
Outdated
Show resolved
Hide resolved
...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Outdated
Show resolved
Hide resolved
…stem/Runtime/InteropServices/JavaScript/Marshaling/JSMarshalerArgument.Task.cs Co-authored-by: Marek Fišera <mara@neptuo.com>
# Conflicts: # src/mono/browser/runtime/startup.ts
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
JSProxyContext.NativeTID
toJSNativeTID
InstallMainSynchronizationContext
andGCHandle
backTask
pre-resolved on another threadWaitAssertsOnJSInteropThreads
mono_wasm_invoke_method_bound
tomono_wasm_invoke_method
mono_wasm_invoke_method_raw
in favor ofmono_wasm_invoke_method
segmentation-rules
andsymbols
assets into workermanaged-exports.ts
runtimeHelpers.proxyGCHandle
appendElementOnExit
in workerloaderHelpers.invariantMode
local variablethread_dump
for detached threads and UI threadmono_wasm_init_threads
asynchronously and earlier and moved the codestart_runtime
invoke_method_and_handle_exception
toinvoke_sync_method
RuntimeHelpers
init ofnativeExit
andnativeAbort