-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Read/Write Async test #98432
Add Read/Write Async test #98432
Conversation
Tagging subscribers to this area: @mangod9 Issue DetailsAdding a read/write async test that run with both the Windows and the Portable thread pool. It also verifies that the events can be fired using either thread pool implementation.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly nits, just a couple of comments.
src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Adding a read/write async test that runs with the Windows thread pool enabled.
It also checks that the thread pool IO events are fired correctly, verifying the changes made in #97365.