Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SocketsHttpHandler's content encoding comparison case-insensitive #98475

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Make SocketsHttpHandler's content encoding comparison case-insensitive #98475

merged 1 commit into from
Feb 15, 2024

Conversation

stephentoub
Copy link
Member

Fixes #98236

@ghost ghost assigned stephentoub Feb 15, 2024
@ghost
Copy link

ghost commented Feb 15, 2024

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #98236

Author: stephentoub
Assignees: stephentoub
Labels:

area-System.Net.Http
Milestone: -

wfurt
wfurt approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
However, it does not make the comparisons case insensitive, right?
e.g. It just handles another variant we did not before but I'm not sure if that covers spirit of the RFC.

@wfurt
Copy link
Member

wfurt commented Feb 15, 2024

(and does not address the Did not handle "Gzip")

@stephentoub
Copy link
Member Author

stephentoub commented Feb 15, 2024 •
edited
Loading

However, it does not make the comparisons case insensitive, right?

It does.

Are you looking at the test file maybe?

@stephentoub
Copy link
Member Author

and does not address the Did not handle "Gzip"

It does, it's now using StringComparison.OrdinalIgnoreCase.

@wfurt
Copy link
Member

wfurt commented Feb 15, 2024

Are you looking at the test file maybe?

yes. actually I did. never mind.

@build-analysis build-analysis bot mentioned this pull request Feb 15, 2024
Closed
ManickaP
ManickaP approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephentoub stephentoub merged commit 64204a5 into dotnet:main Feb 15, 2024
109 of 111 checks passed
@stephentoub stephentoub deleted the fixdecompression branch February 15, 2024 13:14
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2024
@karelz karelz added this to the 9.0.0 milestone May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wfurt wfurt wfurt approved these changes

@ManickaP ManickaP ManickaP approved these changes

Assignees

@stephentoub stephentoub

Labels
area-System.Net.Http
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

Decompression handler is case-sensitive
4 participants
@stephentoub @wfurt @ManickaP @karelz