-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SDK to preview 1 release #98476
Conversation
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsVersions taken from https://dotnet.microsoft.com/en-us/download/dotnet/9.0. related: dotnet/arcade#14485
|
cc @lewing for wasm/wasi failures. rest of the legs are green. |
Repo owners should make an attempt at investigating first. |
Ok, sorry about that. Only reason I pinged you was because your were pinged the last time we had this error:
|
OK I think I understand the issue. Submitted #98942 |
@ellahathaway - Can you take a look at what happened here? The UX here when there are multiple source-build dependencies on the same repo isn't ideal. I was expecting a failure with an obvious error message. |
Investigating. The duplication should've caused an error like dotnet/arcade-validation#4190 (comment) since the SB metadata tag was on a non-intermediate, so I'm guessing that a different exception was hit first. Follow up: I replicated the duplicate package reference in another repo and ran |
I suspect this changed with dotnet/sourcelink@0647320. @tmat PTAL From a successful build without the new SDK: |
Trying something out with the latest commit. |
Looking at the commits in sourcelink again, I think it's dotnet/sourcelink#1150 which regressed this. |
Shall we try setting https://github.com/dotnet/arcade/pull/14485/files#diff-9da24614831c308827a1ae533ffea392c97638c261dd42bd0f5226baa136d16eR16 here? WASM failure is related to CPM, somehow SDK is seeing the Version Details infra as CPM? 👀 |
We already set that: Line 343 in 51b51bf
This is a bigger issue. Sourcelink doesn't work at all when cloning from a local file path. For arcade the workaround was just to set this property manually as arcade doesn't validate that sourcelink works correctly, but runtime does. Note that this only affects the source-build repo build. |
Yes this really is dotnet/sourcelink#1150. @dotnet/source-build-internal sourcelink doesn't support cloning from a local path anymore which source-build does. This affects all repositories that use the inner clone feature and upgrade to a .NET 8.0.2xx or 9.0 Preview 1 SDK. It's probably only runtime that errors because we have a test that validates that sourcelink works correctly. Related: dotnet/source-build#4117 |
Due to the new vstest terminal logger we didn't get the test list anymore from stdout. Fix by reverting back to the old logger.
React to breaking change in NuGet/NuGet.Client@c9b81ab
@am11 After this PR, I found that coreclr test is not built. However, I don't know well about SDK so I don't know how to fix it. Could you please take a look at this? How to reproduce Error message
|
@clamp03 #97791 (comment), we need to pass |
@am11 Thank you for the comment. I tried to build coreclr test with
Actually, I checked the build with/without only this PR. (If head commit is CC @dotnet/samsung |
Versions taken from https://dotnet.microsoft.com/en-us/download/dotnet/9.0.
related: dotnet/arcade#14485