Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linux musl arm32 helix image to Alpine 3.17 #98531

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

lbussell
Copy link
Contributor

Alpine 3.16 builds are failing in dotnet/dotnet-buildtools-prereqs-docker#966 and there is not a known/easy solution. This PR updates to Alpine 3.17 so that we can just delete the older Alpine images.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 15, 2024
@ghost ghost assigned lbussell Feb 15, 2024
Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since .NET 9 will not support Alpine 3.16 at release time, LGTM!

Copy link
Member

@epananth epananth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@epananth epananth self-requested a review February 16, 2024 00:10
Copy link
Member

@hoyosjs hoyosjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might still have to service those for 8.0 and below. It ends support in May though so we might just get away with it.

@jkoritzinsky
Copy link
Member

/azp run runtime

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@danmoseley danmoseley added area-Infrastructure-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Feb 20, 2024
@ghost
Copy link

ghost commented Feb 20, 2024

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Alpine 3.16 builds are failing in dotnet/dotnet-buildtools-prereqs-docker#966 and there is not a known/easy solution. This PR updates to Alpine 3.17 so that we can just delete the older Alpine images.

Author: lbussell
Assignees: lbussell
Labels:

area-Infrastructure-coreclr

Milestone: -

@lbussell
Copy link
Contributor Author

I'm not sure why this PR is failing. @hoyosjs any idea what's going on?

Installing collected packages: cffi
  Attempting uninstall: cffi
    Found existing installation: cffi 1.15.1
    Uninstalling cffi-1.15.1:
      Successfully uninstalled cffi-1.15.1
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
helix-scripts 20231128.5 requires cffi==1.15.1, but you have cffi 1.16.0 which is incompatible.
Successfully installed cffi-1.16.0
WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
+ export 'PYTHONPATH=/root/helix/scripts:'
+ cd /root/helix/work/workitem/e
+ mkdir -p /home/helixbot/dotnetbuild/dumps/
+ /root/helix/work/correlation/scripts/2ddd54f1c5cd417282b3a2b8ad4a0ba2/execute.sh
+ export '__TestArchitecture=arm'
+ ./RunTests.sh --runtime-path /root/helix/work/correlation
========================= Begin custom configuration settings ==============================
export __IsXUnitLogCheckerSupported=1
========================== End custom configuration settings ===============================
----- start Fri Feb 16 19:37:57 UTC 2024 =============== To repro directly: =====================================================
pushd .
/root/helix/work/correlation/dotnet exec --runtimeconfig System.Net.Quic.Functional.Tests.runtimeconfig.json --depsfile System.Net.Quic.Functional.Tests.deps.json xunit.console.dll System.Net.Quic.Functional.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing 
popd
===========================================================================================================
/root/helix/work/workitem/e /root/helix/work/workitem/e
  Discovering: System.Net.Quic.Functional.Tests (method display = ClassAndMethod, method display options = None)
MsQuic supported and using 'libmsquic.so 2.3.0.0 (7ea0e2e640008ad5c86d8d31e0cd186399b6b404)'.
  Discovered:  System.Net.Quic.Functional.Tests (found 133 of 145 test cases)
  Starting:    System.Net.Quic.Functional.Tests (parallel test collections = on [2 threads], stop on fail = off)
    System.Net.Quic.Tests.MsQuicPlatformDetectionTests.UnsupportedPlatforms_ThrowsPlatformNotSupportedException [SKIP]
      Condition(s) not met: "IsQuicUnsupported"
./RunTests.sh: line 180:    22 Segmentation fault      (core dumped) "$RUNTIME_PATH/dotnet" exec --runtimeconfig System.Net.Quic.Functional.Tests.runtimeconfig.json --depsfile System.Net.Quic.Functional.Tests.deps.json xunit.console.dll System.Net.Quic.Functional.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing $RSP_FILE
/root/helix/work/workitem/e

@hoyosjs
Copy link
Member

hoyosjs commented Feb 23, 2024

I don't have a good grasp of this one at the moment, I see a crash within libmsquic but not sure why (cc: @wfurt )

@wfurt
Copy link
Member

wfurt commented Feb 24, 2024

@CarnaViire
Copy link
Member

@lbussell @hoyosjs I've put up a PR to disable QUIC tests as we can't use the workaround on 3.17 (#99020); hopefully that should unblock you once it's merged.

cc @ManickaP @wfurt

@hoyosjs hoyosjs merged commit 6b8d34b into dotnet:main Feb 28, 2024
102 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

8 participants