[main] Update dependencies from dotnet/roslyn

[dotnet-maestro]

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

• Subscription: 037eb78c-9902-4cb9-856d-08db8ed7cafd
• Build: 20240311.10
• Date Produced: March 12, 2024 3:46:39 AM UTC
• Commit: c3565da812d99adf841cb96a764a27d8a93e22ef
• Branch: refs/heads/main

• Updates:
  • Microsoft.SourceBuild.Intermediate.roslyn: from 4.10.0-2.24114.13 to 4.10.0-3.24161.10
  • Microsoft.CodeAnalysis: from 4.10.0-2.24114.13 to 4.10.0-3.24161.10
  • Microsoft.CodeAnalysis.CSharp: from 4.10.0-2.24114.13 to 4.10.0-3.24161.10
  • Microsoft.Net.Compilers.Toolset: from 4.10.0-2.24114.13 to 4.10.0-3.24161.10

[lewing]

@BrzVlad 'MONO interpreter: NIY encountered in method (wrapper dynamic-method) object:lambda_method12 (System.Runtime.CompilerServices.Closure)'

[ghost]

Tagging subscribers to this area: @BrzVlad, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

Issue Details

---

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

• Subscription: 037eb78c-9902-4cb9-856d-08db8ed7cafd
• Build: 20240220.1
• Date Produced: February 20, 2024 12:10:58 PM UTC
• Commit: 25aa74d725e801b8232dbb3e5abcda0fa72da8c5
• Branch: refs/heads/main

• Updates:
  • Microsoft.SourceBuild.Intermediate.roslyn: from 4.10.0-2.24114.13 to 4.10.0-2.24120.1
  • Microsoft.CodeAnalysis: from 4.10.0-2.24114.13 to 4.10.0-2.24120.1
  • Microsoft.CodeAnalysis.CSharp: from 4.10.0-2.24114.13 to 4.10.0-2.24120.1
  • Microsoft.Net.Compilers.Toolset: from 4.10.0-2.24114.13 to 4.10.0-2.24120.1

Author:	dotnet-maestro[bot]
Assignees:	-
Labels:	area-Codegen-Interpreter-mono, area-codeflow
Milestone:	-

[lewing]

this hit #98730

[lewing]

A value of type 'System.Threading.Lock' converted to a different type will use likely unintended monitor-based locking in 'lock' statement.

[mangod9]

@jaredpar @kouvel the new Lock related Roslyn changes are causing a build break in Lock.cs:

 @azure-pipelines azure-pipelines
/ runtime (Build Libraries Build linux arm64 Debug)

src/libraries/System.Private.CoreLib/src/System/Threading/Lock.cs#L123
src/libraries/System.Private.CoreLib/src/System/Threading/Lock.cs(123,21): error CS9216: (NETCORE_ENGINEERING_TELEMETRY=Build) A value of type 'System.Threading.Lock' converted to a different type will use likely unintended monitor-based locking in 'lock' statement. 

Perhaps the static analyzer needs a special case here?

[AaronRobinsonMSFT]

I'm able to reproduce this locally. I have a DMP. There is a lot going on here. Still looking into the core issue. My repro is a Checked runtime, Debug Libraries on x86 Windows.

[AaronRobinsonMSFT]

Quick update. Running on main, the dotnet.exe process peaks at 300 MB and then settles between 110 MB and 140 MB for the rest of the tests. When running with from this branch, the dotnet.exe process peaks at 1.7 GB and crashes. I'm doing a bisect now to try and determine where this was introduced, but from what I've seen this is starting to look like something introduced by the new Roslyn API.

[AaronRobinsonMSFT]

The current working theory for the OOM issue is a confluence of two changes.

1. Converted the interop tests to use ParallelTheory.
2. Improvments in the Workspace layer in the Roslyn SDK.

The result is that ParallelTheory permits most/all tests to run concurrently. Improvements in the Roslyn SDK have been to reduce the inherent limits on concurrent Compilation. The result is the Roslyn SDK has been streamlined and the GC and Finalizer thread can't keep up with the increased garbage produced by the Compilations.

The potential OOM was simply hidden because we are genuinly generating too much garbage and this was fine until Roslyn made performance improvements and let us hurt ourselves.

[AaronRobinsonMSFT]

@stephentoub Looks like the WASM runtime doesn't support something.

[03:20:40] info: [FAIL] System.Text.RegularExpressions.Tests.RegexRustTests.MatchStartAndEndPositions
[03:20:40] info: System.PlatformNotSupportedException : Cannot wait on monitors on this runtime.
[03:20:40] info:    at System.Threading.Monitor.ObjWait(Int32 millisecondsTimeout, Object obj)
[03:20:40] info:    at System.Threading.Monitor.Wait(Object obj, Int32 millisecondsTimeout)
[03:20:40] info:    at System.Threading.ManualResetEventSlim.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
[03:20:40] info:    at System.Threading.Tasks.Task.SpinThenBlockingWait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
[03:20:40] info:    at System.Threading.Tasks.Task.InternalWaitCore(Int32 millisecondsTimeout, CancellationToken cancellationToken)
[03:20:40] info:    at System.Threading.Tasks.Task.InternalWait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
[03:20:40] info:    at System.Threading.Tasks.Task`1[[System.Text.RegularExpressions.Regex[], System.Text.RegularExpressions, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]].GetResultCore(Boolean waitCompletionNotification)
[03:20:40] info:    at System.Threading.Tasks.Task`1[[System.Text.RegularExpressions.Regex[], System.Text.RegularExpressions, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]].get_Result()
[03:20:40] info:    at System.Text.RegularExpressions.Tests.RegexHelpers.GetRegexes(RegexEngine engine, ValueTuple`4[] regexes)
[03:20:40] info:    at System.Text.RegularExpressions.Tests.RegexRustTests.MatchStartAndEndPositions_MemberData()+MoveNext()
[03:20:40] info:    at System.Linq.Enumerable.IEnumerableSelectIterator`2[[System.Object, System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.Object[], System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].MoveNext()

[stephentoub]

@sbomer, @agocke, all failures are known except for this one:

❌ Mono.Linker.Tests.TestCases.All.DataFlow(t: \"DynamicObjects\")
Exception Message
Expected to find warning: warning IL2026: Mono.Linker.Tests.Cases.DataFlow.DynamicObjects.InvocationOnDynamicType.ObjectCreationDynamicArgument(): and message containing 'Microsoft.CSharp.RuntimeBinder.Binder.InvokeConstructor', but no such message was found.\nLogged messages:\nILC: Trim analysis warning IL2026: Mono.Linker.Tests.Cases.DataFlow.DynamicObjects.DynamicInRequiresUnreferencedCodeClass.Test(): Using member 'Mono.Linker.Tests.Cases.DataFlow.DynamicObjects.DynamicInRequiresUnreferencedCodeClass.ClassWithRequires.MethodWithDynamicArg(Object)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. message.\nILC: Trim analysis warning IL2026: Mono.Linker.Tests.Cases.DataFlow.DynamicObjects.InvocationOnDynamicTypeInMethodWithRUCDoesNotWarnTwoTimes.Test(): Using member 'Mono.Linker.Tests.Cases.DataFlow.DynamicObjects.InvocationOnDynamicTypeInMethodWithRUCDoesNotWarnTwoTimes.MethodWithRequires()' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. We should only see the warning related to this annotation, and none about the dynamic type.\nILC: AOT analysis warning IL3050: Mono.Linker.Tests.Cases.DataFlow.DynamicObjects.InvocationOnDynamicTypeInMethodWithRUCDoesNotWarnTwoTimes.Test(): Using member 'Mono.Linker.Tests.Cases.DataFlow.DynamicObjects.InvocationOnDynamicTypeInMethodWithRUCDoesNotWarnTwoTimes.MethodWithRequires()' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. We should only see the warning related to this annotation, and none about the dynamic type.\nILC: AOT analysis warning IL3050: Mono.Linker.Tests.Cases.DataFlow.DynamicObjects.DynamicInRequiresUnreferencedCodeClass.ClassWithRequires.MethodWithDynamicArg(Object): Using member 'System.Runtime.CompilerServices.CallSite`1<Action`2<CallSite,Object>>.Create(CallSiteBinder)' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. Creating arrays at runtime requires dynamic code generation.\nILC: Trim analysis warning IL2026: Mono.Linker.Tests.Cases.DataFlow.DynamicObjects.DynamicIndexerAccess.Read(Object): Using member 'Microsoft.CSharp.RuntimeBinder.Binder.GetIndex(CSharpBinderFlags,Type,IEnumerable`1<CSharpArgumentInfo>)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Using dynamic types might cause types or members to be removed by trimmer.\nILC: AOT analysis warning IL3050: Mono.Linker.Tests.Cases.DataFlow.DynamicObjects.DynamicIndexerAccess.Read(Object): Using member 'System.Runtime.CompilerServices.CallSite`1<Func`4<CallSite,Object,Int32,Object>>.Create(CallSiteBinder)' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. Creating arrays at runtime requires dynamic code generation.\nILC: Trim analysis warning IL2026: Mono.Linker.Tests.Cases.DataFlow.DynamicObjects.DynamicIndexerAccess.Write(Object): Using member 'Microsoft.CSharp.RuntimeBinder.Binder.SetIndex(CSharpBinderFlags,Type,IEnumerable`1<CSharpArgumentInfo>)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Using dynamic types might cause types or members to be removed by trimmer.\nILC: AOT analysis warning IL3050: Mono.Linker.Tests.Cases.DataFlow.DynamicObjects.DynamicIndexerAccess.Write(Object): Using member 'System.Runtime.CompilerServices.CallSite`1<Func`5<CallSite,Object,Int32,Int32,Object>>.Create(CallSiteBinder)' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. Creating arrays at runtime requires dynamic code generation.\nILC: Trim analysis warning IL2026: Mono.Linker.Tests.Cases.DataFlow.DynamicObjects.DynamicMemberReference.Read(Object): Using member 'Microsoft.CSharp.RuntimeBinder.Binder.GetMember(CSharpBinderFlags,String,Type,IEnumerable`1<CSharpArgumentInfo>)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Using dynamic types might cause types or members to be removed by trimmer.\nILC: AOT analysis warning IL3050: Mono.Linker.Tests.Cases.DataFlow.DynamicObjects.DynamicMemberReference.Read(Object): Using member 'System.Runtime.CompilerServices.CallSite`1<Func`3<CallSite,Object,Object>>.Create(CallSiteBinder)' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. Creating arrays at runtime requires dynamic code generation.\nILC: Trim analysis warning IL2026: Mono.Linker.Tests.Cases.DataFlow.DynamicObjects.DynamicMemberReference.Write(Object): Using member 'Microsoft.CSharp.RuntimeBinder.Binder.SetMember(CSharpBinderFlags,String,Type,IEnumerable`1<CSharpArgumentInfo>)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Using dynamic types might cause types or members to be removed by trimmer.\nILC: AOT analysis warning IL3050: Mono.Linker.Tests.Cases.DataFlow.DynamicObjects.DynamicMemberReference.Write(Object): Using member 'System.Runtime.CompilerServices.CallSite`1<Func`4<CallSite,Object,Int32,Object>>.Create(CallSiteBinder)' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. Creating arrays at runtime requires dynamic code generation.\n/_/src/libraries/System.Linq.Expressions/src/System/Runtime/CompilerServices/CallSiteOpsReflectionCache.cs(36): AOT analysis warning IL3050: System.Runtime.CompilerServices.CallSiteOpsReflectionCache`1..cctor(): Using member 'System.Runtime.CompilerServices.CallSiteOps.Bind<T>(CallSiteBinder,CallSite`1<T>,Object[])' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. Creating arrays at runtime requires dynamic code generation.
Stack Trace
   at Mono.Linker.Tests.TestCasesRunner.ResultChecker.VerifyLoggedMessages(AssemblyDefinition original, TrimmingTestLogger logger, Boolean checkRemainingErrors) in /_/src/coreclr/tools/aot/ILCompiler.Trimming.Tests/TestCasesRunner/ResultChecker.cs:line 345
   at Mono.Linker.Tests.TestCasesRunner.ResultChecker.AdditionalChecking(TrimmedTestCaseResult linkResult, AssemblyDefinition original) in /_/src/coreclr/tools/aot/ILCompiler.Trimming.Tests/TestCasesRunner/ResultChecker.cs:line 157
   at Mono.Linker.Tests.TestCasesRunner.ResultChecker.Check(TrimmedTestCaseResult testResult) in /_/src/coreclr/tools/aot/ILCompiler.Trimming.Tests/TestCasesRunner/ResultChecker.cs:line 70
   at Mono.Linker.Tests.TestCases.All.Run(String testName) in /_/src/coreclr/tools/aot/ILCompiler.Trimming.Tests/TestCases/TestSuites.cs:line 155
   at Mono.Linker.Tests.TestCases.All.DataFlow(String t) in /_/src/coreclr/tools/aot/ILCompiler.Trimming.Tests/TestCases/TestSuites.cs:line 16
   at InvokeStub_All.DataFlow(Object, Span`1)
   at System.Reflection.MethodBaseInvoker.InvokeWithOneArg(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

Is this new?

[sbomer]

Working on a fix. The test in question is sensitive to Roslyn codegen for dynamic that changed.

[sbomer]

I'm just commenting out this test to unblock dependency flow. I couldn't find a way to make Roslyn generate a call to Binder.InvokeConstructor, so disabling the test for now.

[stephentoub]

Remaining failure is known. Thanks, all.