Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: test the new cse policy in jit-experimental #98777

Merged

Conversation

AndyAyersMS
Copy link
Member

Add some minimal CI testing for this new CSE heuristic.

Remove testing of cross-block assertion prop, since it's now on by default.

Contributes to #92915.

Add some minimal CI testing for this new CSE heuristic.

Remove testing of cross-block assertion prop, since it's now on by default.

Contributes to dotnet#92915.
@ghost ghost assigned AndyAyersMS Feb 21, 2024
@AndyAyersMS
Copy link
Member Author

@EgorBo PTAL
cc @dotnet/jit-contrib

@AndyAyersMS
Copy link
Member Author

@agocke what's the magic incantation needed to get build analysis to rerun? I am never sure if my attempt to add a new issue are successful or not.

@agocke
Copy link
Member

agocke commented Feb 22, 2024

I click the re-run here:
image

If there's another way, I don't know about it

@agocke
Copy link
Member

agocke commented Feb 22, 2024

It looks like this was hit by the temporary Build Analysis outage -- it's being fixed right now.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 23, 2024
@AndyAyersMS
Copy link
Member Author

It looks like this was hit by the temporary Build Analysis outage -- it's being fixed right now.

Thanks, that's what I was doing... would be nice to get some kind of "in progress" notice when this happens, otherwise I can't tell if rerunning is really happening.

@AndyAyersMS
Copy link
Member Author

Going to merge this... build analysis should be green.

@AndyAyersMS AndyAyersMS merged commit 52c14fb into dotnet:main Feb 23, 2024
177 of 181 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants