-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace unaligned casts in SpanHelpers.Memmove #98812
Conversation
@MihuBot -arm64 |
Do you mind if we merge this after #98623 to avoid resolving conflicts there because that PR is already too big? |
Tagging subscribers to this area: @dotnet/area-system-buffers Issue DetailsFix #83709 IL size is reduced by ~140 bytes.
|
Fix dotnet#83709 IL size is reduced by ~140 bytes.
@EgorBo Build analysis is green, could you please review. |
@MihuBot -arm64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, lgtm
Fix dotnet#83709 IL size is reduced by ~140 bytes.
This PR seems to introduce a lot of regressions for Mono dotnet/perf-autofiling-issues#33182 @EgorBot -commit 5aee4f4 vs previous -mono --filter System.Memory.ReadOnlyMemory.ToArray |
Benchmark results on Intel
|
^ toolchain is misleading, but PR means "before the PR" and "Main" means "PR change" |
This PR seems to introduce a lot of regressions for Mono dotnet/perf-autofiling-issues#33182 @EgorBot -commit 5aee4f4 vs previous -mono --filter System.Memory.ReadOnlyMemory.ToArray --envvars MONO_VERBOSE_METHOD:Memmove |
Benchmark results on Intel
|
Asm diff: https://www.diffchecker.com/70tCMUog/ (not sure which is PR and which is Main) |
Fix #83709.
No diffs expected.
IL size is reduced by ~140 bytes.