Vectorize LeadingZeroCount & TrailingZeroCount. #98877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-system-numerics |
stephentoub
reviewed
Feb 23, 2024
...em.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorPrimitives.LeadingZeroCount.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Feb 23, 2024
...m.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorPrimitives.TrailingZeroCount.cs
Show resolved
Hide resolved
stephentoub
reviewed
Feb 23, 2024
...m.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorPrimitives.TrailingZeroCount.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Feb 23, 2024
...m.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorPrimitives.TrailingZeroCount.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Feb 23, 2024
...m.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorPrimitives.TrailingZeroCount.cs
Outdated
Show resolved
Hide resolved
| if (sizeof(T) == 8) return Avx512CD.VL.LeadingZeroCount(x.AsUInt64()).As<ulong, T>(); | ||
| } | ||
|
|
||
| Debug.Assert(AdvSimd.IsSupported); |
There was a problem hiding this comment.
We want these to be explicit. It makes it work better with the trimmer for other platforms and matches the requirements we have for corelib around using intrinsics (this isn't in corelib, but its still good to follow those practices as its required for special crossgen handling to ever be usable for the assembly).
There was a problem hiding this comment.
The rest of TP is like this, as I'd previously addressed feedback around throws. I suggest this be merged as is, and if we want to change the approach, it be done across all operators en mass together.
...em.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorPrimitives.LeadingZeroCount.cs
Outdated
Show resolved
Hide resolved
This was referenced Feb 26, 2024
System.Net.Http.Functional.Tests.HttpMetricsTest_Http11_Async_HttpMessageInvoker Test failure
#96407
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using code from #98275 and 1da8d2f. Contributes to #97193.