Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser][MT] fix various issues and enable System.Runtime.InteropServices.JavaScript.Tests #99000

Merged
merged 5 commits into from
Mar 11, 2024
Merged

[browser][MT] fix various issues and enable System.Runtime.InteropServices.JavaScript.Tests #99000

merged 5 commits into from
Mar 11, 2024

Conversation

lewing
Copy link
Member

@lewing lewing commented Feb 27, 2024 •
edited by pavelsavara
Loading

fixes

  • revert mistake in get_arg_bool that C# bool is 4 bytes introduced in [browser][MT] cleanup #98672
  • free GCHandles during JSProxyContext dispose
  • SetSynchronizationContext for JSWebWorker
  • don't call managed side during forceDisposeProxies for GCHandles via force_dispose_proxies_in_progress
  • cache http_wasm_supports_streaming_request and http_wasm_supports_streaming_response detection
  • abandon resove/reject before other asserts via is_runtime_running

@ghost ghost assigned lewing Feb 27, 2024
@lewing lewing marked this pull request as draft February 27, 2024 17:12
This was referenced Feb 27, 2024
Closed
Closed
@pavelsavara pavelsavara added the arch-wasm WebAssembly architecture label Mar 4, 2024
@ghost
Copy link

ghost commented Mar 4, 2024

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Reverts #98951

Author: lewing
Assignees: lewing
Labels:

arch-wasm, area-Build-mono
Milestone: -

@pavelsavara pavelsavara marked this pull request as ready for review March 8, 2024 17:18
@pavelsavara pavelsavara added the os-browser Browser variant of arch-wasm label Mar 8, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Mar 8, 2024
pavelsavara
pavelsavara approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@pavelsavara pavelsavara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if this could pass build now

@pavelsavara pavelsavara self-assigned this Mar 8, 2024
@pavelsavara
Copy link
Member

/azp run runtime-wasm

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member

/azp run runtime-wasm

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Mar 9, 2024
Open
@pavelsavara pavelsavara changed the title Revert "[wasm] Disable the System.Runtime.InteropServices.JavaScript tests on mt whi…" [browser][MT] fix various issues and enable System.Runtime.InteropServices.JavaScript.Tests Mar 10, 2024
@pavelsavara
Copy link
Member

/azp run runtime-wasm

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Mar 10, 2024
Closed
Closed
@pavelsavara pavelsavara merged commit 2909fe8 into main Mar 11, 2024
136 checks passed
@jkotas jkotas deleted the revert-98951-disable-mt-jsinterop branch March 15, 2024 23:36
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pavelsavara pavelsavara pavelsavara approved these changes

Assignees

@lewing lewing

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lewing @pavelsavara