Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the wasRelocHandled flag #99008

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Set the wasRelocHandled flag #99008

merged 1 commit into from
Feb 27, 2024

Conversation

kunalspathak
Copy link
Member

In my earlier fix in #98840, I forgot to set the flag wasRelocHandled to indicate the the relocation was handled.

 Fixes# #98996

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 27, 2024
@ghost ghost assigned kunalspathak Feb 27, 2024
@ghost
Copy link

ghost commented Feb 27, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

In my earlier fix in #98840, I forgot to set the flag wasRelocHandled to indicate the the relocation was handled.

 Fixes# #98996

Author: kunalspathak
Assignees: kunalspathak
Labels:

area-CodeGen-coreclr
Milestone: -

@kunalspathak
Copy link
Member Author

I verified applyDiff for smoke collection for below configurations and they are clean.

  • windows/x64
  • linux/x64
  • linux/arm64

@kunalspathak kunalspathak merged commit d06ebfe into dotnet:main Feb 27, 2024
109 of 115 checks passed
@kunalspathak kunalspathak deleted the relocType branch February 27, 2024 21:29
This was referenced Feb 27, 2024
Closed
Closed
@filipnavara filipnavara mentioned this pull request Feb 28, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BruceForstall BruceForstall BruceForstall approved these changes

Assignees

@kunalspathak kunalspathak

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kunalspathak @BruceForstall