-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mono] Add basic ref struct support for generic parameter #99081
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good!
I'm very pleasantly surprised it's such a small change
src/tests/Loader/classloader/generics/ByRefLike/InvalidCSharp.il
Outdated
Show resolved
Hide resolved
@fanyang-mono The CoreCLR support, along with more tests, was merged with #98070. We should merge in main and remove the disabled test attributes. |
…s with byreflike type parameter
This PR is ready to be reviewed agian. @lambdageek |
CI failures are not related to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the generic instance check for load/store static fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks Fan!
Fixes #94421. Fixes #99165
Contributes to #94415
This PR enables ref struct type being used in generic parameters and added/fixed exceptions being thrown when ref struct type being used with box/newobj/static field by Mono JIT/AOT/interpreter.