Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unhandled exception when dependency is missing #99117

Merged
merged 1 commit into from
Feb 29, 2024

Commits on Feb 29, 2024

  1. Fix unhandled exception when dependency is missing

    ASPNet team has found that the new exception handling doesn't handle
    unhandled exception caused by a missing dependency assembly correctly.
    Instead of invoking the unhandled exception machinery in the native
    code, it actually exited back to the managed exception handler loop with
    a failure from the the SfiInit.
    
    The reason is that in that specific case, the check if there are still
    managed frames on the stack that's done by checking if there is any
    explicit frame doesn't work, since there is a helper method frame.
    
    This change fixes it by moving the unhandled exception check to the end
    of the SfiInit when we haven't found any managed frame through the stack
    walker.
    janvorli committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    30e60af View commit details
    Browse the repository at this point in the history