[mono][interp] Super instruction tweaks #99319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrzVlad
requested review from
lewing,
pavelsavara,
vargaz and
kotlarmilos
as code owners
ghost
assigned 
|
Tagging subscribers to this area: @BrzVlad, @kotlarmilos Issue Detailsnull
|
kg
reviewed
Mar 5, 2024
kg
reviewed
Mar 5, 2024
| @@ -3224,32 +3207,15 @@ get_sreg_imm (TransformData *td, int sreg, gint16 *imm, int result_mt) | |||
| ct = interp_get_const_from_ldc_i8 (def); | |||
| else | |||
| return FALSE; | |||
| gint64 min_val, max_val; | |||
There was a problem hiding this comment.
I assume the removal of the I1/U1 stuff here is verified harmless
kg
approved these changes
Mar 5, 2024
This was referenced Mar 6, 2024
They have little benefit. Also fix oversight which resulted in using MINT_LDC_I4_S only for byte sized integers.
…ions Make `get_sreg_imm` more flexible, by returning the immediate value and the mint type that this value can fit in. Simplify return immediate handling by also applying conversion to immediate value, if necessary.
We will avoid running it if we know will do another iteration later (especially useful when first iteration is ssa disabled). It can still happen for it to run multiple times (when bblock optimization requests retry), but this should be very rare. This will save compilation time and should also remove the necessity of handling super instructions in constant folding pass. Reverts dotnet#99055 since it is no longer necessary.
Also add instructions for and/or + immediates.
and + ldc will already be transformed to a superinstruction, so this can also be simplified.
BrzVlad
force-pushed
the
feature-interp-super-ldc
branch
from
1736865
to
09ff7cd
Compare
BrzVlad
changed the title
|
CI didn't run after the last commit so I merged main. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.