Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[main] Update dependencies from dotnet/roslyn-analyzers" #99327

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Revert "[main] Update dependencies from dotnet/roslyn-analyzers" #99327

merged 1 commit into from
Mar 5, 2024

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Mar 5, 2024

Reverts #98984

@ghost ghost assigned jkotas Mar 5, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Mar 5, 2024
@jkotas jkotas requested a review from kg March 5, 2024 20:14
@kg
Copy link
Member

kg commented Mar 5, 2024

I opened #99328 real quick to see if that's an acceptable solution, but a revert seems appropriate too.

@jkotas jkotas merged commit 496f96e into main Mar 5, 2024
11 of 144 checks passed
@jkotas jkotas deleted the revert-98984-darc-main-416d4d4d-20d6-4eec-8a7e-9a4970612cbf branch March 5, 2024 20:17
@jkotas jkotas mentioned this pull request Mar 5, 2024
Closed
This was referenced Mar 5, 2024
Open
Closed
Closed
Closed
Closed
buyaa-n added a commit to buyaa-n/runtime that referenced this pull request Mar 6, 2024
@buyaa-n
Reapply "[main] Update dependencies from dotnet/roslyn-analyzers (dot…
21c5639 
…net#98984)" (dotnet#99327)
@buyaa-n buyaa-n mentioned this pull request Mar 6, 2024
Merged
@build-analysis build-analysis bot mentioned this pull request Mar 6, 2024
Closed
buyaa-n added a commit that referenced this pull request Mar 7, 2024
@buyaa-n
Update dependencies from dotnet/roslyn-analyzers, config new analyzers (
c6906ae 
#99343)

* Reapply "[main] Update dependencies from dotnet/roslyn-analyzers (#98984)" (#99327)

* Configure new analyzers severity in src and test projects

* Fix some of CA2263 warnings
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kg kg kg approved these changes

Assignees

@jkotas jkotas

Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkotas @kg