Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser][wbt] Extend delay when waiting for URLs #99446

Merged

Conversation

maraf
Copy link
Member

@maraf maraf commented Mar 8, 2024

From testing in #98981, we found out that the server is responding and working. For unknown reason it seems that when running from different directory, the default timeout of 30 seconds isn't enough.

Here we are allowing additional 30 seconds. After first 30s a message is provided.

I'll leave the tracking issue open to see if this is enough.

Contributes to #94821

@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono labels Mar 8, 2024
@maraf maraf self-assigned this Mar 8, 2024
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@maraf
Copy link
Member Author

maraf commented Mar 8, 2024

/azp run runtime

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@maraf
Copy link
Member Author

maraf commented Mar 8, 2024

/azp run runtime

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@maraf maraf marked this pull request as ready for review March 8, 2024 20:06
@maraf maraf requested a review from ilonatommy as a code owner March 8, 2024 20:06
@maraf maraf requested review from lewing and akoeplinger March 8, 2024 20:07
@maraf maraf merged commit a8509d9 into dotnet:main Mar 9, 2024
22 checks passed
@maraf maraf deleted the BrowserRunWithDifferentAppBundleLocationsMoreTime branch March 22, 2024 14:05
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants