Enable NativeAOT win-x86 runtime tests

[filipnavara]

See #99688 (comment) for results of the last run.

[filipnavara]

Can someone run /azp run runtime-nativeaot-outerloop, please?

[jakobbotsch]

/azp run runtime-nativeaot-outerloop

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[filipnavara]

Can I get a re-run please? (Most of the individual commits are submitted as separate PRs; I'll rebase once they land and leave just the YAML changes here.)

[jakobbotsch]

/azp run runtime-nativeaot-outerloop

[filipnavara]

Remaining failed runtime test should be fixed by #99753. Since the Azure bot didn't respond to the /azp run runtime-nativeaot-outerloop command (😒) I pushed the additional change here as well.

[EgorBo]

/azp run runtime-nativeaot-outerloop

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[filipnavara]

Nearly all MSQUIC tests started failing on the linux-arm (32-bit) leg. Wasn't there a MSQUIC update done recently that could have broken something? /cc @ManickaP

[MichalPetryka]

Nearly all MSQUIC tests started failing on the linux-arm (32-bit) leg. Wasn't there a MSQUIC update done recently that could have broken something? /cc @ManickaP

#99681

[filipnavara]

Rebased over the merged fixes. Can I get a /azp run runtime-nativeaot-outerloop rerun please?

[am11]

@filipnavara, I think being a member of @dotnet/external-ci-access, you can also trigger the leg with /az commands. :)

[filipnavara]

/azp run runtime-nativeaot-outerloop

[azure-pipelines]

Commenter does not have sufficient privileges for PR 99688 in repo dotnet/runtime

[filipnavara]

@filipnavara, I think being a member of @dotnet/external-ci-access, you can also trigger the leg with /az commands. :)

Cool. Didn't know that was a thing. Unfortunately, it doesn't work.

[khellang]

@am11 And by @'ing that team, you just sent a notification to 166 people 😆 Hello everyone 👋

[am11]

Commenter does not have sufficient privileges for PR 99688 in repo dotnet/runtime

That's sad. I think dotnet/runtime is not part of that group?

And by @'ing that team, you just sent a notification to 166 people 😆 Hello everyone 👋

Ah, sorry I forgot to wrap it in ` 😂 but good things are happening here 😉

[filipnavara]

This is unintended change. I'll get rid of it with next rebase.

[khellang]

but good things are happening here 😉

For sure. Keep up the good work @filipnavara! 💪😎

[jakobbotsch]

/azp run runtime-nativeaot-outerloop

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jkotas]

The System.Threading.Tests failure is in similar part of code that I tried to fix with #99934 (which did fix it in Release builds):

I think the stackunwind for the assembly code also needs to simulate pop of the 16 bytes worth of arguments. It means that you would need to special-case this method.

An alternative is to move the null check to managed code like I have done in #96916 for CoreCLR. It would allow the interlocked helper to be implemented in C/C++ instead of assembly.

[filipnavara]

I think the stackunwind for the assembly code also needs to simulate pop of the 16 bytes worth of arguments. It means that you would need to special-case this method.

I think you are right!

An alternative is to move the null check to managed code like I have done in #96916 for CoreCLR. It would allow the interlocked helper to be implemented in C/C++ instead of assembly.

Sounds like a reasonable thing to do. I'll submit a PR later today (at least for moving the null check, and if feasible the move to C++ as well).

[MihaZupan]

/azp run runtime-nativeaot-outerloop

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[vcsjones]

/azp run runtime-nativeaot-outerloop

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[filipnavara]

🎉 All the runtime tests passed! 🎉

Libraries tests:

• System.IO.Tests.File_GetSetTimes_SafeFileHandle.WritingShouldUpdateWriteTime_After_SetLastAccessTime seems like reoccurrence of Failing test -System.IO.Tests.File_GetSetTimes_SafeFileHandle_Pathless.WritingShouldUpdateWriteTime_After_SetLastAccessTime on windows/x86 #95298
• System.Net.Http.Functional.Tests.HttpMetricsTest_Http11_Async.RequestDuration_ConnectionClosedWhileReceivingHeaders_Recorded is System.Net.Http.Functional.Tests.HttpMetricsTest_Http11_Async_HttpMessageInvoker Test failure #96407

[filipnavara]

This is finally unblocked since all dependent PRs were merged.

[MichalStrehovsky]

/azp run runtime-nativeaot-outerloop

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[MichalStrehovsky]

/azp run runtime-nativeaot-outerloop

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[MichalStrehovsky]

Thank you!