Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport VMR patch for cross builds #99702

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Backport VMR patch for cross builds #99702

merged 2 commits into from
Mar 14, 2024

Conversation

jkoritzinsky
Copy link
Member

Backport the VMR patch that fixed our cross-build issues.

Backport the VMR patch that fixed our cross-build issues.
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkoritzinsky I just noticed that we already pass the -cross switch in:

<InnerBuildArgs Condition="'$(TargetArch)' != '$(_hostArch)' and '$(ShortStack)' != 'true'">$(InnerBuildArgs) $(FlagParameterPrefix)cross</InnerBuildArgs>

@jkoritzinsky
Copy link
Member Author

That condition isn't correct for the x64 cross build. I'll merge the two conditions.

@jkoritzinsky jkoritzinsky merged commit 6133293 into main Mar 14, 2024
174 of 180 checks passed
@jkotas jkotas deleted the jkoritzinsky-patch-1 branch March 15, 2024 23:37
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants