Use JitEnableOptionalRelocs in getHelperFtn #99791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 15, 2024
|
@jkotas PTAL VM change, this removes noise for jit-diff MihuBot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some helper calls may be emitted as direct calls or indirect depending on non-deterministic timing. We try to avoid things like that with
jit-diffsso I decided to re-useJitEnableOptionalRelocsthat is already used for the same reason.I didn't want to introduce a new knob here, a better way is to probably rename
JitEnableOptionalRelocsto something generic likeDiffableorDeterministic, but that will require changes in two repos to sync (jit-utils and MihuBot)cc @MihaZupan this fixes the noise in MihuBot we talked about today