-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0-staging] disable optimizations for PopCount #99832
[release/8.0-staging] disable optimizations for PopCount #99832
Conversation
avoid using an optimization which might fail on non-SSE4 cpus.
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-approval to unblock regression in 8.0.3
relevant VS Developer Community feedback item : https://developercommunity.visualstudio.com/t/Visual-Studio-1793-crashes-during-star/10614986 |
* disable optimizations for PopCount avoid using an optimization which might fail on non-SSE4 cpus. * remove whitespace for jit-format --------- Co-authored-by: Manish Godse <61718172+mangod9@users.noreply.github.com>
* disable optimizations for PopCount avoid using an optimization which might fail on non-SSE4 cpus. * remove whitespace for jit-format --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Manish Godse <61718172+mangod9@users.noreply.github.com>
Backport of #99796 to release/8.0-staging
/cc @mangod9
Customer Impact
Regression
This was a regression in 8.0.3 due to a compiler update which caused popcnt instruction from being emitted. This causes .NET applications to stop working on cpus without SSE4 support.
Testing
Verified locally that popcnt is not being generated, and also that inlining for these methods is disabled.
Risk
[Low]